Skip to content

Comments

Rename keyring token label#45

Merged
gtsiolis merged 1 commit intomainfrom
george/rename-keyring
Feb 20, 2026
Merged

Rename keyring token label#45
gtsiolis merged 1 commit intomainfrom
george/rename-keyring

Conversation

@gtsiolis
Copy link
Member

@gtsiolis gtsiolis commented Feb 20, 2026

This will update the keyring item label used for storing the CLI auth token for clearer and more accurate naming in system credential managers. The previous label was CLI-specific and less readable in OS keychain.

See also relevant discussion and #44 for more context.

BEFORE AFTER
Screenshot 2026-02-20 at 14 29 08 Screenshot 2026-02-20 at 14 29 34

@coderabbitai
Copy link

coderabbitai bot commented Feb 20, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The PR updates the keyring authentication token label from "lstk auth token" to "LocalStack Auth Token" across two files: the token storage implementation and its integration tests.

Changes

Cohort / File(s) Summary
Keyring Label Update
internal/auth/token_storage.go, test/integration/main_test.go
Updated the keyringAuthTokenLabel constant from "lstk auth token" to "LocalStack Auth Token" for improved readability.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • silv-io
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Rename keyring token label' clearly and concisely summarizes the main change in the pull request, which is updating the keyring label from 'lstk auth token' to 'LocalStack Auth Token'.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose of renaming the keyring token label for improved clarity in system credential managers, and includes supporting context and visual comparison.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch george/rename-keyring

Comment @coderabbitai help to get the list of available commands and usage tips.

keyringPassword = "lstk-keyring"
keyringFilename = "keyring"
keyringAuthTokenLabel = "lstk auth token"
keyringAuthTokenLabel = "LocalStack Auth Token"
Copy link
Member Author

@gtsiolis gtsiolis Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: Alternatively, we could simplify as LocalStack if we ever want to bundle more settings or credentials in a JSON format, etc.

@gtsiolis gtsiolis self-assigned this Feb 20, 2026
@gtsiolis
Copy link
Member Author

Thanks for taking a look, @carole-lavillonniere! 😁

@gtsiolis gtsiolis merged commit 66df90a into main Feb 20, 2026
8 checks passed
@gtsiolis gtsiolis deleted the george/rename-keyring branch February 20, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants