Add concurrency control and job timeouts in CI#343
Open
gtsiolis wants to merge 3 commits into
Open
Conversation
gtsiolis
force-pushed
the
devx-939-add-concurrency-control-and-job-timeouts-in-ci
branch
from
389a4e1 to
c4f861f
Compare
gtsiolis
added
semver: patch
docs: skip
gtsiolis
force-pushed
the
devx-939-add-concurrency-control-and-job-timeouts-in-ci
branch
from
c4f861f to
98d8c45
Compare
gtsiolis
changed the title
gtsiolis
force-pushed
the
devx-939-add-concurrency-control-and-job-timeouts-in-ci
branch
2 times, most recently
from
29443f9 to
486add7
Compare
Member
Author
|
This should be fairely trivial to review, anyone else from @localstack/devx wanna give it a try? |
gtsiolis
force-pushed
the
devx-939-add-concurrency-control-and-job-timeouts-in-ci
branch
from
02eb96a to
473aad3
Compare
- Cancel superseded CI runs on the same PR (keyed by PR number); push/tag/ release runs get unique groups via run_id so the release pipeline's workflow_call is never interrupted. - Add timeout-minutes to every CI job to replace the implicit 6h default. - Group Dependabot minor/patch updates per ecosystem (gomod, github-actions); major updates still open individual PRs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
TestAzStopInterceptionNoOpWhenNotIntercepting is the only az test that runs the real az binary against a temp HOME on Windows. az spawns background processes that hold handles open under HOME\.azure, so t.TempDir()'s auto RemoveAll fails with "being used by another process" and fails an otherwise-passing test. Use a best-effort temp HOME (azTempHome) that ignores cleanup errors instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The unique-group fallback (github.run_id for non-PR events) already guarantees push/tag/release runs are never cancelled, so the github.event_name conditional was redundant with cancel-in-progress: true.
gtsiolis
force-pushed
the
devx-939-add-concurrency-control-and-job-timeouts-in-ci
branch
from
473aad3 to
8ea1700
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DEVX-939.
Hardens the CI pipeline with three independent, behavior-preserving improvements.
1. PR concurrency cancellation (
.github/workflows/ci.yml)Every push to a PR currently starts a full CI run (lint + goreleaser-check + unit + 6-way integration matrix) and nothing cancels superseded runs. New group:
run_id, so each run gets a unique group and is never cancelled or queued. This deliberately protects the reusableworkflow_callfromautomated-release.yml.2. Per-job timeouts (
.github/workflows/ci.yml)No job set
timeout-minutes, leaving the implicit 6-hour default. A hung Docker/e2e job could occupy a runner for hours. Added: lint 10, goreleaser-check 10, test-unit 15, test-integration 45, test-integration-summary 5, release 30.3. Grouped Dependabot updates (
.github/dependabot.yml)Dependabot could open up to 20 PRs/day (10 gomod + 10 github-actions). Minor/patch updates are now grouped per ecosystem into a single PR; major updates still open individual PRs so breaking bumps stay isolated.
Follow-ups (not in this PR)
majorbump path is half-wired:automated-release.ymlcan compute amajorbump, but the release job validates tags against^v0\.[0-9]+\.[0-9]+$, so a v1+ tag would be created and then fail to publish. Needs a product decision.