Skip to content

Egress auto retry [1/N]#1427

Open
milos-lk wants to merge 10 commits intomainfrom
egress-auto-retry
Open

Egress auto retry [1/N]#1427
milos-lk wants to merge 10 commits intomainfrom
egress-auto-retry

Conversation

@milos-lk
Copy link
Contributor

@milos-lk milos-lk commented Feb 25, 2026

Supporting change for implementing egress auto retries. Adding ability to specify the retry count on start egress request as well as in the egress info object which gets communicated to the service where retry decisions are made.

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2026

⚠️ No Changeset found

Latest commit: 37d7b6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

// cloud only
bool cloud_backup_enabled = 10;
double estimated_cpu = 14;
int32 retries = 15;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not feeling too strongly about it, but retry_count sounds clearer to me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second that.

Also, can retry enabled the default behaviour? Egress dying unexpectedly is not user visible. Auto-retry enable would be a better experience it feels like? However, filename/object storage extra objects would be a surprise for users though if it happens automatically.

// cloud only
bool cloud_backup_enabled = 10;
double estimated_cpu = 14;
int32 retries = 15;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second that.

Also, can retry enabled the default behaviour? Egress dying unexpectedly is not user visible. Auto-retry enable would be a better experience it feels like? However, filename/object storage extra objects would be a surprise for users though if it happens automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants