Skip to content

give session e2e start the CLI's own readiness budget #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
u9g merged 1 commit into from
Jul 13, 2026
+5 −1
Merged

give session e2e start the CLI's own readiness budget #908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cmd/lk/session_e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,11 @@ func TestSessionE2E(t *testing.T) {
})

// start: launches the detached daemon and returns once the agent is ready.
startOut, err := run(15*time.Second, "agent", "daemon", "start", "--port", port, entrypoint)
// The CLI itself waits up to 65s for daemon readiness (awaitDaemonReady),
// so give it just over that: on a cold Windows runner the chain of first
// execs (lk.exe, uv, python) can alone eat a tighter budget, and killing
// the command mid-wait loses the CLI's own error report.
startOut, err := run(70*time.Second, "agent", "daemon", "start", "--port", port, entrypoint)
require.NoError(t, err, "session start failed:\n%s", startOut)
require.Contains(t, startOut, "Session started.", "start did not report readiness:\n%s", startOut)

Expand Down
Loading