fix(workflows): unstall credit card repeat-back confirmation#6447
Open
chenghao-mou wants to merge 1 commit into
Open
fix(workflows): unstall credit card repeat-back confirmation#6447chenghao-mou wants to merge 1 commit into
chenghao-mou wants to merge 1 commit into
Conversation
…it card task During repeat-back confirmation the LLM often routes the repeated value back to update_* (or claims confirmation without any tool call), which re-arms confirmation and stalls the task group (dead air until the next user utterance). Raise a ToolError pointing at the confirm tool when update_* receives the pending value again, add the explicit tool-invocation guard from name.py to the three instruction templates, and extend the update return strings to cover late update calls that arrive after the user already repeated the value. Fixes AGT-3139 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During repeat-back confirmation the LLM often routes the repeated value back to
update_*instead ofconfirm_*; the task re-arms confirmation, the model then claims the value is confirmed without any tool call, and the task group stalls (dead air until the caller speaks again).update_*now raises a ToolError redirecting the model toconfirm_*when it receives the pending value again, all three instruction templates get the explicit tool-invocation guard fromname.py, and the update return strings cover the late-update case where the caller already repeated the value. A different value still re-arms confirmation, so mid-confirmation corrections are unchanged.Known gap: if the model never calls
update_*until after the repeat (or calls no tool at all), the task can still stall; prompt guidance alone did not fix that for gpt-5.2 at low reasoning effort. Structural fix (forcedtool_choicewhile confirmation is pending) tracked in AGT-3140.Repro used for both the bug and verification:
lk agent daemontext session againstGetCreditCardTask(require_confirmation=True).Fixes AGT-3139
🤖 Generated with Claude Code