fix(voice): don't drop the realtime turn when the chat-ctx push times out#6445
Open
ByteMaster-1 wants to merge 1 commit into
Open
fix(voice): don't drop the realtime turn when the chat-ctx push times out#6445ByteMaster-1 wants to merge 1 commit into
ByteMaster-1 wants to merge 1 commit into
Conversation
… out
In _realtime_reply_task the chat-context push before generate_reply was a bare
await: the OpenAI plugin raises RealtimeError("update_chat_ctx timed out.")
after its 5s ack timeout, which propagated as an unhandled task error and
killed the turn — the user asked a question and got silence.
The push is best-effort: the plugin sends all conversation.item.create events
before waiting for acks, so on timeout the server usually already has the
items. Handle it accordingly:
- RealtimeError (provider-reported, e.g. ack timeout): log and proceed with
generate_reply anyway
- any other exception: mark the SpeechHandle done with the error so the app
observes the failed turn via SpeechHandle.exception() instead of a crashed
task
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Author
|
@longcw This is the second follow-up from the #6352 rescope: the update_chat_ctx push inside generate_reply no longer kills the turn on the plugin's ack timeout (best-effort — the items were already sent), and unexpected failures land on SpeechHandle.exception() instead of crashing the turn task. Small diff + unit tests. PTAL when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incident. Calling session.generate_reply(user_input=...) on a realtime session pushes the message via update_chat_ctx before requesting the reply. That await was unguarded: when the OpenAI plugin's 5s ack timeout fired (RealtimeError("update_chat_ctx timed out.")), the error propagated as an unhandled exception in the turn task — the turn died, the user got silence, and nothing was reported on the SpeechHandle.
Fix. The push is best-effort — the plugin sends all conversation.item.create events before waiting for acks, so a timeout means missing acknowledgements, not missing items. So:
RealtimeError → log a warning and still call generate_reply (the server usually has the context).
Unexpected exceptions → mark the SpeechHandle done with the error, observable via SpeechHandle.exception() #6304 , without crashing the turn task.
Deliberately out of scope: no retry of the push itself, and no change to the plugin's timeout; the two other update_chat_ctx call sites (interrupted-sync and tool-output paths) already have their own RealtimeError handling and are untouched.