feat(adk): align stores with ADK 2 contract#525
Open
cofin wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
==========================================
+ Coverage 74.90% 75.12% +0.22%
==========================================
Files 442 443 +1
Lines 55120 57603 +2483
Branches 8697 8891 +194
==========================================
+ Hits 41287 43276 +1989
- Misses 11149 11523 +374
- Partials 2684 2804 +120
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event_datarecord shape.SQLSpecSessionServicefor async ADK callers.Validation
make lintmake type-check.venv/bin/python -m pytest tests/unit/extensions/test_adk tests/unit/adapters/test_oracledb/test_oracle_adk_store.py tests/unit/adapters/test_psycopg/test_adk_store.py tests/unit/adapters/test_spanner/test_adk_store.py tests/integration/adapters/sqlite/extensions/adk/test_memory_store.py tests/integration/adapters/sqlite/extensions/adk/test_owner_id_column.py tests/integration/adapters/duckdb/extensions/adk/test_memory_store.py tests/integration/adapters/duckdb/extensions/adk/test_store.py tests/integration/adapters/adbc/extensions/adk/test_dialect_support.py tests/integration/adapters/adbc/extensions/adk/test_owner_id_column.py tests/integration/adapters/adbc/extensions/adk/test_memory_store.py -qgit diff --checkrg -n "event_json" sqlspec/extensions/adk sqlspec/adapters tests/integration/adapters/*/extensions/adk tests/unit/extensions/test_adk tests/unit/adapters -g '*.py'