Open
Conversation
CatarinaGamboa
requested changes
Feb 9, 2026
Collaborator
CatarinaGamboa
left a comment
There was a problem hiding this comment.
For the nullness check, I think we need more cases, like what if we declare the var and it doesn't have a value?
There are full tools just for the nullness checking (e.g., NullAway https://github.com/uber/NullAway)
PS: this would be so much easier if it were 2 prs, one for null and one for boxed types -- the boxed types would be an easy squash and merge
| if (refinementFound == null) { | ||
| refinementFound = new Predicate(); | ||
| } | ||
| if (Utils.isBoxedType(localVariable.getType()) && !Utils.isNullLiteral(e)) { |
Collaborator
There was a problem hiding this comment.
why is this necessary? and why wouldnt we put a createNullEq in the "only declaration, no assignment"?
Collaborator
Author
There was a problem hiding this comment.
- That's the case where we declare a variable of boxed type (e.g.
Integer) and it is not null, so it carries the refinement"_ != null" - I didn't consider uninitialized variables, should we handle that case?
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for null checking in LiquidJava.
It also allows us to refine boxed types which previously were also not supported (
Integer,Boolean,Short,Long,FloatandDouble).Changes
Refinements Language
nullliteral to the grammarLiteralNullAST nodeTyping
nullcan be assigned to any non-primitive type_ != null, while the literalnullcarries the refinement_ == nullZ3 Translation
java.lang.Objectnullliterals are converted to the sort of the other operand to match both sortsjava.lang.Integer=>Int) to avoid errors like“Sorts java.lang.Integer and Int are incompatible"Simplification
s == -1 && s != nullsimplifies tos == -1instead of-1 != nullTesting