Change rpc-bind-address to use dualstack and add DISABLE_IPV6 var#321
Open
miyurusankalpa wants to merge 2 commits intolinuxserver:masterfrom
Open
Change rpc-bind-address to use dualstack and add DISABLE_IPV6 var#321miyurusankalpa wants to merge 2 commits intolinuxserver:masterfrom
miyurusankalpa wants to merge 2 commits intolinuxserver:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Change rpc-bind-address setting to dual stack mode. Additionally add
DISABLE_IPV6env variable for people who have disabled IPv6 via kernel settings.Benefits of this PR and context:
This makes the docker image usable on IPv6 only hosts and additionally, will solve issues for some people who uses the localhost URL.
How Has This Been Tested?
IPv6 only tested and working.
Tested that it binds to both protocols, from the single setting.
Tested the new env variable change to settings.json correctly
Source / References: