[BLOCKED] Add support for mijn.host DNS plugin#618
Draft
Sausageroll2077 wants to merge 2 commits into
Draft
Conversation
Adds certbot-dns-mijn-host as a DNSPLUGIN option (mijn-host), including the plugin in both Dockerfiles, a credentials template under dns-conf, and the DNSPLUGIN list in readme-vars.yml. Closes linuxserver#606 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds mijn.host as a DNS validation provider, resolving #606.
Changes:
certbot-dns-mijn-hosttoDockerfileandDockerfile.aarch64(kept in alphabetical order).root/defaults/dns-conf/mijn-host.ini.mijn-hostto theDNSPLUGINoptions list and a changelog entry inreadme-vars.yml.The plugin follows certbot's standard naming convention (authenticator
dns-mijn-host,dns-mijn-host-credentials,dns-mijn-host-propagation-seconds), so no changes to the certbot init logic were required.Benefits of this PR and context:
Closes #606. Adds DNS-01 validation support for another provider (mijn.host), requested by users.
How Has This Been Tested?
Built the full image locally against the patched plugin (the branch from mijnhost/certbot-dns-mijn-host#15, which removes the
josepypin):pipresolves the entire plugin set cleanly —certbot 5.6.0,acme 5.6.0,josepy 2.2.0,certbot-dns-mijn-host 0.0.8.certbot plugins --authenticatorscorrectly registersdns-mijn-host:Actual certificate issuance against a live mijn.host domain has not been tested, as I don't have a mijn.host account — the issue reporter (#606) may be able to validate end-to-end.
Source / References:
certbot-dns-mijn-hoston PyPI)