init-plex-chown/run: use TMPDIR instead of hardcoded /run/plex-temp#448
init-plex-chown/run: use TMPDIR instead of hardcoded /run/plex-temp#448evan314159 wants to merge 2 commits intolinuxserver:masterfrom
Conversation
|
I am a bot, here are the test results for this PR:
|
|
Please rebase this against master and then I'm think I'm happy to merge it. |
Changes init-plex-chown/run to use TMPDIR instead of hardcoded /run/plex-temp Plex uses TMPDIR to store transcodes of music to WAV format for music analysis (and maybe other things). LS.io container sets TMPDIR=/run/plex-temp. With read-only root this means the /run tmpfs needs to have enough memory to store music analysis transcodes. LS.io container hardcoded /run/plex-temp in init so TMPDIR could not be flexibly changed -- changed to use TMPDIR and clean on restart in case of unclean shutdown. Plex container is marked as supporting read-only root.
evan314159
force-pushed
the
readonly-tmpdir
branch
from
6dcdb82 to
094d207
Compare
|
Rebased against master -- thank you! |
|
I am a bot, here are the test results for this PR:
|
There was a problem hiding this comment.
Sorry, didn't notice this. You need to edit the readme-vars.yaml. Any direct changes to the readme.md will be lost when the repo templating runs on build.
There was a problem hiding this comment.
Sorry, these are my first contributions to LS.io and I did not see the readme-vars.yaml. Hopefully third time's a charm!
|
I am a bot, here are the test results for this PR:
|
3 participants
Description:
Changes init-plex-chown/run to use TMPDIR instead of hardcoded /run/plex-temp
Plex uses TMPDIR to store transcodes of music to WAV format for music
analysis (and maybe other things).
LS.io container sets TMPDIR=/run/plex-temp in Dockerfile. With read-only root this
means the /run tmpfs needs to have enough memory to store music analysis
transcodes.
LS.io container hardcoded /run/plex-temp in init so TMPDIR could not be
flexibly changed -- changed to use TMPDIR and clean on restart in case
of unclean shutdown.
Plex container is marked as supporting read-only root.
Benefits of this PR and context:
Compatibility with read-only root with /run as a small tmpfs and TMPDIR moved to a non-tmpfs to service transcoding.
How Has This Been Tested?
Tested (1) with default TMPDIR (2) with TMPDIR set to /transcode/temp with /transcode being a bind mount.
Source / References: