add error handling and message for when a browser is lacking#399
Open
jflec415git wants to merge 1 commit intolinuxmint:masterfrom
Open
add error handling and message for when a browser is lacking#399jflec415git wants to merge 1 commit intolinuxmint:masterfrom
jflec415git wants to merge 1 commit intolinuxmint:masterfrom
Conversation
… for a browser no longer on their system. previous behavior was to freeze up briefly and then act like the user never touched the button
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webapps would briefly freeze if the user sought to edit a webapp when its supported browser was no longer installed.
in on_edit_button
show_browser_not_found_dialog
"The browser associated with this webapp no longer exists on your system. Please reinstall to edit or use this app."