Skip to content

add error handling and message for when a browser is lacking#399

Open
jflec415git wants to merge 1 commit intolinuxmint:masterfrom
jflec415git:missing-browser-edit-dialog
Open

add error handling and message for when a browser is lacking#399
jflec415git wants to merge 1 commit intolinuxmint:masterfrom
jflec415git:missing-browser-edit-dialog

Conversation

@jflec415git
Copy link
Copy Markdown

webapps would briefly freeze if the user sought to edit a webapp when its supported browser was no longer installed.

in on_edit_button

  • updated the list[0] syntax to a next() statement to get the selected_browser_index
  • added if block to handle None occurrence due to a missing browser

show_browser_not_found_dialog

  • new method to handle dialog
  • puts up a simple message that the browser is missing. exact text below:
    "The browser associated with this webapp no longer exists on your system. Please reinstall to edit or use this app."

… for a browser no longer on their system. previous behavior was to freeze up briefly and then act like the user never touched the button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant