Fix Chromium web app grouping in Cinnamon with manual StartupWMClass detection#395
Open
sohailb108 wants to merge 1 commit intolinuxmint:masterfrom
Open
Fix Chromium web app grouping in Cinnamon with manual StartupWMClass detection#395sohailb108 wants to merge 1 commit intolinuxmint:masterfrom
sohailb108 wants to merge 1 commit intolinuxmint:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Cinnamon, different Chromium web apps can get the icon of the first one launched and group together.
I found that
StartupWMClassin the.desktopfile didn't match the window class fromxprop WM_CLASSand updatingStartupWMClassto match fixed the issue.Since Chromium sets the window class at runtime, correct automatic detection at add time sounds impossible.
So this PR adds a manual fix in Web Apps with a new toolbar button.
How to use it:
xprop WM_CLASSis read, and the firstWM_CLASSvalue is saved intoStartupWMClassin the corresponding.desktopfile.How to test:
StartupWMClasswas updated to theWM_CLASSvalue returned byxprop.Changes:
Fixes #100