enabled browser editing for webapps#394
Open
jflec415git wants to merge 1 commit intolinuxmint:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed add_specific_widgets list and changed on_add_button and on_edit_button to automatically show browser_label and browser_combo
edit_webapps already rebuilds the execution line via get_exec_string, same as add_webapps
the rest of edit_webapps is browser agnostic
these changes add the final functionality still hidden by add_specific_widgets
addresses issue Can't change browser engine after web app creation #384 and a personal desire
If I somehow missed something, please tell me, so I may fix it.