Fix usb speed display

[pilatomic]

Fix the display of the USB speed :

1. Speeds in Gpbs are not converted before being displayed (unit is Gpbs, but the actual value is still in Mbps)
2. Speeds that were not integer caused the function to fail.

To fix it, I replaced all the %d strings by %s, so that we can directly print strings.
When the speed is high enough, we still convert it to Gpbs
When it isnt, directly print the value obtained, it is already in Mbps and requires no conversion.

Closes #111

(It builds upon my previous MR #113)

I still need to test on another PC with 20 gpbs USB, hence marking as "draft" for one day.

[pilatomic]

I can confirm all the speed are displayed correctly (both in the "Speed" column and in controller names)

Before :

After :

Removing the "draft" status

[mtwebster]

Hi, I mentioned this already in your other PR:

• Don't run makepot or update PO files - we do this ourselves near a major release.
• Don't change the Mbps format string - you can just call str() on speed_mbps - this avoids having to retranslate this.
• The Gbps string I guess is ok to change, but I wonder if it makes more sense to do soemthing like:

return _("%0.1f Gbps") % (val / 1000)

sample output:

In [11]: print("%0.1f Gbps" % (1024 / 1000))
1.0 Gbps

In [12]: print("%0.1f Gbps" % (1204 / 1000))
1.2 Gbps

In [13]: print("%s Gbps" % ("%d" % (1024 / 1000)))
1 Gbps

In [14]: print("%s Gbps" % ("%d" % (1500 / 1000)))
1 Gbps

In [15]: print("%0.1f Gbps" % (1500 / 1000))
1.5 Gbps

[pilatomic]

Hi,

I have cleaned up the PR.

I'm a bit lost about the Mbps string. The original string uses the %d formatter, which prevents the "1.5 Mbps" speed from being displayed correctly.

I don't see a way to fix it without changing the formatter. Am I missing an obvious way ?

[clefebvre]

Hi,

This isn't a critical bug, we can push it to master without having to backport it to 22.3. So with that in mind, don't worry about changing the translation strings.

[pilatomic]

Hi,

In that case, I think this is ready to be merged.

Thank you.

[mtwebster]

This is still overly complex. Don't use %d to perform a type conversion for you, just do the type conversion and use '%d' in the string.

return _("%d Gbps") % int(val / 1000)

[pilatomic]

My intention was to achieve consistency between Gpbs and Mbps translation string, by having "%s" in both.
I understand it makes the code more complicated than necessary.
Will fix.

[mtwebster]

This doesn't matter to translators. You're using the wrong tool to force an integer.