Skip to content

ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]#195

Merged
richm merged 1 commit intomainfrom
ci-container-improvements
Mar 11, 2026
Merged

ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]#195
richm merged 1 commit intomainfrom
ci-container-improvements

Conversation

@richm
Copy link
Contributor

@richm richm commented Mar 11, 2026

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use newer testing tooling and optimize container-based test execution.

CI:

  • Use Ansible 2.20 for Fedora 43 qemu and container test scenarios in the integration test workflow.
  • Bump tox-lsr from 3.16.0 to 3.17.0 across GitHub Actions workflows to pick up improved test behavior.
  • Adjust container test job environment so requirements and callback plugins are only processed on the first test run to speed up subsequent runs.

…r fedora 43 [citest_skip]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner March 11, 2026 00:17
@richm richm self-assigned this Mar 11, 2026
@sourcery-ai
Copy link

sourcery-ai bot commented Mar 11, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI workflows to use tox-lsr 3.17.0 and Ansible 2.20 for Fedora 43-based qemu and container tests, and adjusts container test environment variables to leverage new tox-lsr behavior for faster runs while maintaining full checks on the first test.

Sequence diagram for CI interaction with updated tox_lsr_3_17_0 and Ansible_2_20

sequenceDiagram
  actor Developer
  participant GitHub
  participant GitHub_Actions as GitHub_Actions_Workflow
  participant Tox as tox
  participant ToxLSR as tox_lsr_3_17_0
  participant Ansible as Ansible_2_20
  participant Env as Fedora_43_Test_Env

  Developer->>GitHub: Open_or_update_PR
  GitHub->>GitHub_Actions: Trigger_CI_workflows

  GitHub_Actions->>GitHub_Actions: Setup_Python_environment
  GitHub_Actions->>GitHub_Actions: pip3_install_tox_and_tox_lsr_3_17_0

  GitHub_Actions->>Tox: Invoke_tox_with_ci_env
  Tox->>ToxLSR: Load_tox_lsr_plugins_and_config

  ToxLSR->>Env: Start_container_or_qemu_tests_Fedora_43
  Env->>Ansible: Execute_playbooks_with_Ansible_2_20
  Ansible-->>Env: Test_results

  Env-->>ToxLSR: Optimized_container_test_output_and_status
  ToxLSR-->>Tox: Aggregate_results
  Tox-->>GitHub_Actions: Pass_fail_status
  GitHub_Actions-->>GitHub: Report_CI_status_on_PR
  GitHub-->>Developer: Display_updated_CI_results
Loading

File-Level Changes

Change Details Files
Bump tox-lsr version from 3.16.0 to 3.17.0 across GitHub Actions workflows.
  • Update pip install command in qemu-kvm integration workflow to install tox-lsr 3.17.0 from GitHub
  • Update pip install commands in ansible-lint, ansible-managed-var-comment, ansible-test, and python-unit-test workflows to use tox-lsr 3.17.0
.github/workflows/qemu-kvm-integration-tests.yml
.github/workflows/ansible-lint.yml
.github/workflows/ansible-managed-var-comment.yml
.github/workflows/ansible-test.yml
.github/workflows/python-unit-test.yml
Use Ansible core 2.20 for Fedora 43 qemu and container test scenarios.
  • Change qemu Fedora 43 scenario environment from qemu-ansible-core-2-19 to qemu-ansible-core-2-20
  • Change container Fedora 43 scenario environment from container-ansible-core-2-19 to container-ansible-core-2-20
  • Change container Fedora 43 bootc scenario environment from container-ansible-core-2-19 to container-ansible-core-2-20
.github/workflows/qemu-kvm-integration-tests.yml
Adjust container test loop environment to align with new tox-lsr behavior and speed up repeated runs.
  • Remove LSR_CONTAINER_PROFILE and LSR_CONTAINER_PRETTY debug/profile overrides before running tests
  • Initialize SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to false for the first test iteration
  • Set SKIP_REQUIREMENTS and SKIP_CALLBACK_PLUGINS to true after each test run to skip requirements installation and callback plugin setup on subsequent iterations
.github/workflows/qemu-kvm-integration-tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit b21a412 into main Mar 11, 2026
13 checks passed
@richm richm deleted the ci-container-improvements branch March 11, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant