Open
Conversation
igaw
reviewed
Feb 26, 2026
MichaelRabek
force-pushed
the
musl-build
branch
from
e2e43cc to
22b6270
Compare
MichaelRabek
force-pushed
the
musl-build
branch
2 times, most recently
from
cf4c5fe to
5e28bb4
Compare
igaw
reviewed
Feb 27, 2026
igaw
reviewed
Feb 27, 2026
igaw
reviewed
Feb 27, 2026
MichaelRabek
force-pushed
the
musl-build
branch
2 times, most recently
from
2a1b960 to
4ab15fe
Compare
Collaborator
|
Looks almost ready. There are some checkpatch complains for the last patch. Rest looks good! I would ignore the checkpatch error for the nvme_basename function. This is a bit silly as it is a clear copy from glibc. Let's keep it this way. |
Author
Glad to hear that! Please don't merge this yet though. I'd like to make one more patch with the Alpine build. |
Collaborator
|
I'll wait until you mark it ready for review before I attempt to merge it. |
POSIX states that basename(3) may modify its input string. For this reason, strdup(3) is used in__nvme_transport_handle_open_direct() so that it is safe to call basename(3) on a const char*. This patch introduces an nvme_basename() function that is guaranteed to never modify its input and is thus safe to be used on string literals. It is a copy of basename(3) implementation from glibc. This change allows us to avoid one needless dynamic allocation. Signed-off-by: Michal Rábek <mrabek@redhat.com>
Signed-off-by: Michal Rábek <mrabek@redhat.com>
Signed-off-by: Michal Rábek <mrabek@redhat.com>
Builds with musl libc get broken too often. This patch suggests a new GitHub CI build job to help maintain them being functional. Closes: linux-nvme#2565 Link: linux-nvme#2565 Signed-off-by: Michal Rábek <mrabek@redhat.com>
The 'nvme-cli - uint128' test was failing when build with musl libc. The reason was that musl libc leaves the thousands separator from LC_NUMERIC empty with the fr_FR.utf-8. This patch offers a solution by skipping the test with a warning if the thousands separator cannot be obtained. Signed-off-by: Michal Rábek <mrabek@redhat.com>
The long '--unified' flag of the 'diff' command is GNU specific. Although it is recognized by the Alpine Linux version of 'diff', it is expecting a numeric argument N (number of lines). This difference caused test cases using 'diff' to fail on Alpine. This patch changes that to '-u' which implies N=3 by default on both GNU-based distros and Alpine Linux. Signed-off-by: Michal Rábek <mrabek@redhat.com>
This patch introduces a new CI job that builds the project with musl standard C library in the environment in which it is most commonly used - Alpine Linux. Signed-off-by: Michal Rábek <mrabek@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This series of patches contributes to solving the recurring problem with build fails with
musllibc. It includes proposed build configuration and a new CI build job.Things to check before removing draft status:
muslbuild?