docs: sync Grid Visualizer with account schema changes#531
Conversation
Updates account-types.ts and currencies.ts to match recent OpenAPI schema changes: - EGP_ACCOUNT: Remove deprecated accountNumber/swiftCode fields, add phoneNumber for mobile money, update iban description - COP_ACCOUNT: Add missing bankAccountType field for bank transfers - SWIFT_ACCOUNT: Add new account type with required fields - currencies.ts: Add COP and EGP currencies with payment rails Syncs with commits f5973c2 (account schemas) and related schema updates. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummarySyncs the Grid Visualizer's static data files with recent OpenAPI schema changes:
Confidence Score: 4/5Safe to merge; all changes are visualizer data files with no production logic impact. The COP and EGP additions are complete end-to-end — both the currency entry and the account-type spec are in sync. The SWIFT_ACCOUNT spec is well-formed but has no corresponding currency entry in currencies.ts, leaving it unreachable from the visualizer UI. The change is otherwise correct and isolated to documentation tooling. account-types.ts — the new SWIFT_ACCOUNT entry is defined but unlinked from currencies.ts
|
| Filename | Overview |
|---|---|
| components/grid-visualizer/src/data/account-types.ts | Adds bankAccountType to COP_ACCOUNT, rewrites EGP_ACCOUNT fields (removes deprecated fields, adds phoneNumber), and introduces SWIFT_ACCOUNT. The new SWIFT_ACCOUNT spec is not yet referenced by any currency in currencies.ts, so it is unreachable from the visualizer UI. |
| components/grid-visualizer/src/data/currencies.ts | Adds COP and EGP currency entries correctly wired to their respective account types with Bank Transfer and Mobile Money rails; no issues. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph currencies.ts
COP["COP — Colombian Peso\nallRails: Bank Transfer, Mobile Money"]
EGP["EGP — Egyptian Pound\nallRails: Bank Transfer, Mobile Money"]
end
subgraph account-types.ts
COP_ACCT["COP_ACCOUNT\naccountNumber, bankAccountType, phoneNumber"]
EGP_ACCT["EGP_ACCOUNT\niban, phoneNumber"]
SWIFT_ACCT["SWIFT_ACCOUNT\nswiftCode, bankName, country, accountNumber, iban"]
end
COP -->|accountType| COP_ACCT
EGP -->|accountType| EGP_ACCT
SWIFT_ACCT -.->|no currency entry links here| NOTHING["unreachable in UI"]
style NOTHING fill:#ffdddd,stroke:#cc0000
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
components/grid-visualizer/src/data/account-types.ts:367-377
**SWIFT_ACCOUNT unreachable in the visualizer**
`SWIFT_ACCOUNT` is defined here but no entry in `currencies.ts` sets `accountType: 'SWIFT_ACCOUNT'`, so the `CurrencyPicker` will never expose it and `code-generator.ts` will never look it up. The spec is effectively dead code in the visualizer until a currency (or a separate UI path) references it.
Reviews (1): Last reviewed commit: "docs: sync Grid Visualizer with account ..." | Re-trigger Greptile
| SWIFT_ACCOUNT: { | ||
| accountType: 'SWIFT_ACCOUNT', | ||
| fields: [ | ||
| { name: 'swiftCode', example: 'DEUTDEFF', description: 'SWIFT/BIC code (8-11 characters)' }, | ||
| { name: 'bankName', example: 'Deutsche Bank' }, | ||
| { name: 'country', example: 'NG', description: 'ISO 3166-1 alpha-2 country code' }, | ||
| { name: 'accountNumber', example: '1234567890', description: 'For most corridors' }, | ||
| { name: 'iban', example: 'GB29NWBK60161331926819', description: 'For IBAN-only corridors (e.g. BR, GB)' }, | ||
| ], | ||
| beneficiaryRequired: true, | ||
| }, |
There was a problem hiding this comment.
SWIFT_ACCOUNT unreachable in the visualizer
SWIFT_ACCOUNT is defined here but no entry in currencies.ts sets accountType: 'SWIFT_ACCOUNT', so the CurrencyPicker will never expose it and code-generator.ts will never look it up. The spec is effectively dead code in the visualizer until a currency (or a separate UI path) references it.
Prompt To Fix With AI
This is a comment left during a code review.
Path: components/grid-visualizer/src/data/account-types.ts
Line: 367-377
Comment:
**SWIFT_ACCOUNT unreachable in the visualizer**
`SWIFT_ACCOUNT` is defined here but no entry in `currencies.ts` sets `accountType: 'SWIFT_ACCOUNT'`, so the `CurrencyPicker` will never expose it and `code-generator.ts` will never look it up. The spec is effectively dead code in the visualizer until a currency (or a separate UI path) references it.
How can I resolve this? If you propose a fix, please make it concise.
Summary
Updates the Grid Visualizer data files to match recent OpenAPI schema changes from the last 24 hours.
Account Type Fixes (account-types.ts)
accountNumberandswiftCodefields. AddphoneNumberfor mobile money support. Updateibandescription to clarify it's for bank transfers only.bankAccountTypefield (CHECKING/SAVINGS) required for bank transfers per the updated schema.swiftCode,bankName,country) and optional fields (accountNumber,iban).Currency Additions (currencies.ts)
Related Commits
Test Plan
make lintpasses🤖 Generated with Claude Code