Skip to content

docs: sync Grid Visualizer with account schema changes#531

Open
claude[bot] wants to merge 1 commit into
mainfrom
docs/sync-20260529
Open

docs: sync Grid Visualizer with account schema changes#531
claude[bot] wants to merge 1 commit into
mainfrom
docs/sync-20260529

Conversation

@claude
Copy link
Copy Markdown
Contributor

@claude claude Bot commented May 29, 2026

Summary

Updates the Grid Visualizer data files to match recent OpenAPI schema changes from the last 24 hours.

Account Type Fixes (account-types.ts)

  • EGP_ACCOUNT: Remove deprecated accountNumber and swiftCode fields. Add phoneNumber for mobile money support. Update iban description to clarify it's for bank transfers only.
  • COP_ACCOUNT: Add missing bankAccountType field (CHECKING/SAVINGS) required for bank transfers per the updated schema.
  • SWIFT_ACCOUNT: Add new account type with required fields (swiftCode, bankName, country) and optional fields (accountNumber, iban).

Currency Additions (currencies.ts)

  • COP (Colombian Peso): Added with Bank Transfer and Mobile Money rails
  • EGP (Egyptian Pound): Added with Bank Transfer and Mobile Money rails

Related Commits

Test Plan

  • make lint passes
  • Manual verification in Grid Visualizer UI

🤖 Generated with Claude Code

Updates account-types.ts and currencies.ts to match recent OpenAPI
schema changes:

- EGP_ACCOUNT: Remove deprecated accountNumber/swiftCode fields, add
  phoneNumber for mobile money, update iban description
- COP_ACCOUNT: Add missing bankAccountType field for bank transfers
- SWIFT_ACCOUNT: Add new account type with required fields
- currencies.ts: Add COP and EGP currencies with payment rails

Syncs with commits f5973c2 (account schemas) and related schema updates.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@claude claude Bot requested review from pengying and shreyav May 29, 2026 09:19
@vercel
Copy link
Copy Markdown

vercel Bot commented May 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview, Comment May 29, 2026 9:20am

Request Review

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 29, 2026

Greptile Summary

Syncs the Grid Visualizer's static data files with recent OpenAPI schema changes: EGP_ACCOUNT drops deprecated fields and gains phoneNumber for mobile money, COP_ACCOUNT picks up bankAccountType, and a new SWIFT_ACCOUNT type is defined alongside COP and EGP currency entries.

  • currencies.ts correctly adds COP and EGP with their account types and supported rails (Bank Transfer + Mobile Money).
  • account-types.ts updates EGP and COP field lists and adds the new SWIFT_ACCOUNT spec, but SWIFT_ACCOUNT is not yet linked to any entry in currencies.ts, so it will not appear in the visualizer UI.

Confidence Score: 4/5

Safe to merge; all changes are visualizer data files with no production logic impact.

The COP and EGP additions are complete end-to-end — both the currency entry and the account-type spec are in sync. The SWIFT_ACCOUNT spec is well-formed but has no corresponding currency entry in currencies.ts, leaving it unreachable from the visualizer UI. The change is otherwise correct and isolated to documentation tooling.

account-types.ts — the new SWIFT_ACCOUNT entry is defined but unlinked from currencies.ts

Important Files Changed

Filename Overview
components/grid-visualizer/src/data/account-types.ts Adds bankAccountType to COP_ACCOUNT, rewrites EGP_ACCOUNT fields (removes deprecated fields, adds phoneNumber), and introduces SWIFT_ACCOUNT. The new SWIFT_ACCOUNT spec is not yet referenced by any currency in currencies.ts, so it is unreachable from the visualizer UI.
components/grid-visualizer/src/data/currencies.ts Adds COP and EGP currency entries correctly wired to their respective account types with Bank Transfer and Mobile Money rails; no issues.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph currencies.ts
        COP["COP — Colombian Peso\nallRails: Bank Transfer, Mobile Money"]
        EGP["EGP — Egyptian Pound\nallRails: Bank Transfer, Mobile Money"]
    end

    subgraph account-types.ts
        COP_ACCT["COP_ACCOUNT\naccountNumber, bankAccountType, phoneNumber"]
        EGP_ACCT["EGP_ACCOUNT\niban, phoneNumber"]
        SWIFT_ACCT["SWIFT_ACCOUNT\nswiftCode, bankName, country, accountNumber, iban"]
    end

    COP -->|accountType| COP_ACCT
    EGP -->|accountType| EGP_ACCT
    SWIFT_ACCT -.->|no currency entry links here| NOTHING["unreachable in UI"]

    style NOTHING fill:#ffdddd,stroke:#cc0000
Loading

Fix All in Claude Code

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
components/grid-visualizer/src/data/account-types.ts:367-377
**SWIFT_ACCOUNT unreachable in the visualizer**

`SWIFT_ACCOUNT` is defined here but no entry in `currencies.ts` sets `accountType: 'SWIFT_ACCOUNT'`, so the `CurrencyPicker` will never expose it and `code-generator.ts` will never look it up. The spec is effectively dead code in the visualizer until a currency (or a separate UI path) references it.

Reviews (1): Last reviewed commit: "docs: sync Grid Visualizer with account ..." | Re-trigger Greptile

Comment on lines +367 to +377
SWIFT_ACCOUNT: {
accountType: 'SWIFT_ACCOUNT',
fields: [
{ name: 'swiftCode', example: 'DEUTDEFF', description: 'SWIFT/BIC code (8-11 characters)' },
{ name: 'bankName', example: 'Deutsche Bank' },
{ name: 'country', example: 'NG', description: 'ISO 3166-1 alpha-2 country code' },
{ name: 'accountNumber', example: '1234567890', description: 'For most corridors' },
{ name: 'iban', example: 'GB29NWBK60161331926819', description: 'For IBAN-only corridors (e.g. BR, GB)' },
],
beneficiaryRequired: true,
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 SWIFT_ACCOUNT unreachable in the visualizer

SWIFT_ACCOUNT is defined here but no entry in currencies.ts sets accountType: 'SWIFT_ACCOUNT', so the CurrencyPicker will never expose it and code-generator.ts will never look it up. The spec is effectively dead code in the visualizer until a currency (or a separate UI path) references it.

Prompt To Fix With AI
This is a comment left during a code review.
Path: components/grid-visualizer/src/data/account-types.ts
Line: 367-377

Comment:
**SWIFT_ACCOUNT unreachable in the visualizer**

`SWIFT_ACCOUNT` is defined here but no entry in `currencies.ts` sets `accountType: 'SWIFT_ACCOUNT'`, so the `CurrencyPicker` will never expose it and `code-generator.ts` will never look it up. The spec is effectively dead code in the visualizer until a currency (or a separate UI path) references it.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant