Skip to content

release: use Go 1.26.0#1083

Merged
starius merged 1 commit intolightninglabs:masterfrom
starius:up-go-126
Mar 2, 2026
Merged

release: use Go 1.26.0#1083
starius merged 1 commit intolightninglabs:masterfrom
starius:up-go-126

Conversation

@starius
Copy link
Collaborator

@starius starius commented Mar 2, 2026

Pull Request Checklist

  • Update release_notes.md if your PR contains major features, breaking changes or bugfixes

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the Go version used in the project's release pipeline to Go 1.26.0. This update ensures that all release artifacts are built with the latest stable Go compiler, benefiting from performance improvements, bug fixes, and new language features. The changes involve updating the Docker image used for releases, adjusting the release script's version checks, and synchronizing the release documentation with the new Go version and updated example tags.

Highlights

  • Go Version Update: The Go version used for building releases has been updated from 1.24.9 to 1.26.0 across the release process.
  • Release Documentation Alignment: The docs/release.md file has been updated to reflect the new Go version and to use v0.32.1 as the example release tag, replacing v0.31.x.
  • Dockerfile Base Image: The release.Dockerfile now specifies golang:1.26.0 as its base image, ensuring consistency with the updated Go version.
  • Release Script Configuration: The release.sh script has been modified to expect and validate against Go version 1.26.0 for release builds.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • docs/release.md
    • Updated example make docker-release commands to use v0.32.1-beta tags.
    • Updated example git describe output to v0.32.1-beta-135-g35d0fa26ac.
    • Updated example go install and release.sh commands to reference go1.26.0 and v0.32.1.
    • Updated example LOOPBUILDSYS command to use v0.32.1-beta.
  • release.Dockerfile
    • Changed the base image from golang:1.26 to golang:1.26.0.
  • release.sh
    • Updated the EXPECTED_VERSION variable from go1.24.9 to go1.26.0.
Activity
  • No human activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Member

@alexbosworth alexbosworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally this isn't so hard-coded but i don't know how to achieve that

@starius starius marked this pull request as ready for review March 2, 2026 20:30
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version used for release builds to 1.26.0 and updates version numbers in the release documentation. The changes are straightforward and improve build reproducibility by pinning the Go version in the Dockerfile. I've added one comment regarding updating the go.mod file to keep it in sync with the release toolchain, which is an important step for consistency.


# Make sure we have the expected Go version installed.
EXPECTED_VERSION="go1.24.9"
EXPECTED_VERSION="go1.26.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While updating the expected Go version for the release script is correct, the go.mod file has not been updated and still specifies go 1.25.5. To ensure consistency across the project and prevent potential build issues for developers using an older Go toolchain, it's recommended to also update the go directive in the go.mod file to go 1.26.0.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the previous Go release in go.mod and the most recent Go version in the toolchain / docker / release.

@starius starius merged commit b3cbf2c into lightninglabs:master Mar 2, 2026
9 checks passed
@starius starius deleted the up-go-126 branch March 2, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants