Replace hashes_fuzz with local fuzz gates#4551
Draft
joostjager wants to merge 2 commits intolightningdevkit:mainfrom
Draft
Replace hashes_fuzz with local fuzz gates#4551joostjager wants to merge 2 commits intolightningdevkit:mainfrom
joostjager wants to merge 2 commits intolightningdevkit:mainfrom
Conversation
|
👋 Hi! I see this is a draft PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4551 +/- ##
==========================================
- Coverage 86.99% 86.85% -0.15%
==========================================
Files 163 163
Lines 108635 108703 +68
Branches 108635 108703 +68
==========================================
- Hits 94511 94417 -94
- Misses 11647 11778 +131
- Partials 2477 2508 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the global
hashes_fuzzmode and replaces it with small localcfg(fuzzing)exceptions at the specific hash/MAC verification gates that matter for fuzz coverage.This keeps hashing real by default, updates the few harnesses that depended on fake hashes, and removes the extra
hashes_fuzztarget/config/CI plumbing. A quick profiling session showed that forchanmon_consistency, real hash usage increases runtime by about 15%, which seems acceptable.We don’t toggle
hashes_fuzzper target because it is a build-time cfg on the whole fuzz crate. Doing that cleanly would require target-specific generator/build logic or splitting targets into separate packages, while local gate exceptions give us the same coverage benefit with much less complexity and a smaller blast radius.