Conversation
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
joostjager
force-pushed
the
fuzz-prep
branch
from
c27ec27 to
b3a56d2
Compare
fuzz/src/bin/target_template.txt
Outdated
| TARGET_NAME_test(&data, lightning_fuzz::utils::test_logger::Stdout {}); | ||
| }); | ||
| if res.is_err() { | ||
| std::process::exit(1); |
There was a problem hiding this comment.
Can you explain why this is required? panicing in fn main() should cause the process to exit, no?
There was a problem hiding this comment.
It didn't because the build didn't use panic=abort. Pushed a commit that adds this.
joostjager
force-pushed
the
fuzz-prep
branch
from
b3a56d2 to
ccbc566
Compare
joostjager
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4430 +/- ##
==========================================
- Coverage 85.90% 85.87% -0.04%
==========================================
Files 156 159 +3
Lines 103965 104302 +337
Branches 103965 104302 +337
==========================================
+ Hits 89316 89573 +257
- Misses 12128 12231 +103
+ Partials 2521 2498 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joostjager
force-pushed
the
fuzz-prep
branch
2 times, most recently
from
ba99ab9 to
15a14b4
Compare
|
Verified all fuzzer frontends work with the changes:
|
joostjager
force-pushed
the
fuzz-prep
branch
2 times, most recently
from
613cef0 to
c9876bc
Compare
…dylib This commit makes three related changes to the fuzz infrastructure: 1. Set panic=abort on both dev and release profiles, and remove the dylib crate type (keeping rlib and staticlib). The dylib crate type was added in e28fd78 (2019) for a C-callable harness that was never implemented. Removing dylib is what enables panic=abort, since Rust forces panic=unwind on dylib crates. staticlib is retained as it is compatible with panic=abort. 2. Add stdin_fuzz support: a new Stdout logger, updated target template so that stdin_fuzz calls _test() with Stdout logging, and updated README with usage instructions. This allows reproducing crashes via piped input, useful for git bisect and AI-assisted debugging. 3. Update all fuzzer frontends (AFL, honggfuzz, libfuzzer, stdin_fuzz) to call the _test() functions directly instead of going through the _run() C wrappers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
joostjager
force-pushed
the
fuzz-prep
branch
from
c9876bc to
69e2d8c
Compare
|
I restored the |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
3 participants
Add
stdin_fuzzfeature support to all fuzz targets, allowing test cases to be replayed via stdin when built with--features stdin_fuzz. This is documented in a new section in the fuzz README.