Skip to content

Async channel manager persistence in background processor #4419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joostjager wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Async channel manager persistence in background processor #4419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ae6c3bb
Extract watch_channel_internal/update_channel_internal from Watch impl
joostjager Feb 9, 2026
0a4efd6
Add deferred bool to ChainMonitor
joostjager Feb 9, 2026
04051fb
Implement deferred monitor write queueing and flushing
joostjager Feb 9, 2026
7ce7cf9
f: Fix race between deferred monitor ops and ChannelManager persistence
joostjager Feb 17, 2026
a14744f
Move CM persistence into the Selector loop for true async completion
joostjager Feb 13, 2026
04b4bd3
Log caller location when ChannelManager is marked dirty
joostjager Feb 18, 2026
ed8838d
Skip ChannelManager persistence after monitor update completion
joostjager Feb 18, 2026
5ba66e3
Set needs_persist_flag on every ChannelMonitorUpdate
joostjager Feb 18, 2026
5a5d226
Remove BatchDelay random forwarding delays, always return zero
joostjager Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions fuzz/src/chanmon_consistency.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ impl TestChainMonitor {
Arc::clone(&persister),
Arc::clone(&keys),
keys.get_peer_storage_key(),
false,
)),
logger,
keys,
Expand Down
1 change: 1 addition & 0 deletions fuzz/src/full_stack.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,7 @@ pub fn do_test(mut data: &[u8], logger: &Arc<dyn Logger>) {
Arc::new(TestPersister { update_ret: Mutex::new(ChannelMonitorUpdateStatus::Completed) }),
Arc::clone(&keys_manager),
keys_manager.get_peer_storage_key(),
false,
));

let network = Network::Bitcoin;
Expand Down
1 change: 1 addition & 0 deletions fuzz/src/lsps_message.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ pub fn do_test(data: &[u8]) {
Arc::clone(&kv_store),
Arc::clone(&keys_manager),
keys_manager.get_peer_storage_key(),
false,
));
let best_block = BestBlock::from_network(network);
let params = ChainParameters { network, best_block };
Expand Down
489 changes: 4 additions & 485 deletions lightning-background-processor/src/fwd_batch.rs
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading