Skip to content

fix markdown timestamp rendering for lists #19239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fitztrev wants to merge 13 commits into
base: master
Choose a base branch
from
Open

fix markdown timestamp rendering for lists #19239

fitztrev wants to merge 13 commits into from
+109 −55

Conversation

@fitztrev
Copy link
Member

@fitztrev fitztrev commented Jan 28, 2026

fixes #19236

@allanjoseph98 allanjoseph98 linked an issue Jan 29, 2026 that may be closed by this pull request
Error in timestamps #19247
Open
@fitztrev fitztrev marked this pull request as draft January 29, 2026 14:18
fitztrev added a commit that referenced this pull request Jan 29, 2026
@fitztrev
use munit .ignore for cleaner diff in #19239
0ce5c8c
@fitztrev fitztrev marked this pull request as ready for review January 29, 2026 20:28
@fitztrev
Copy link
Member Author

fitztrev commented Jan 29, 2026

Refactored to create a new TimestampNode using flexmark's custom inline parser extension, instead of parsing it out of the Text node.

I searched github for other scala implementations of customInlineParserExtensionFactory and tried to structure it mostly after those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error in timestamps Something wrong with markdown to html transformation

2 participants

@fitztrev @ornicar