Conversation
Member
|
Just a question beforehand: I'm not 100% sure, but AFAIU |
karel-m
force-pushed
the
pr/fix-LTC_MECC_FP
branch
2 times, most recently
from
077268e to
72c7eae
Compare
karel-m
force-pushed
the
pr/fix-LTC_MECC_FP
branch
4 times, most recently
from
dcfb79e to
98c76a7
Compare
sjaeckel
force-pushed
the
pr/fix-LTC_MECC_FP
branch
from
98c76a7 to
bdaaba6
Compare
Member
|
I'm always again surprised of the speedup that is possible with Timing demo with LTM and ECC-112:
and ECC-520:
|
Running the `timing` demo with `LTC_MECC_FP` enabled gave a segfault, which Valgrind narrowed down to ``` ==135594== Invalid read of size 1 ==135594== at 0x49298C: ss_accel_fp_mul2add (ltc_ecc_fp_mulmod.c:1007) ==135594== by 0x4931C1: ltc_ecc_fp_mul2add (ltc_ecc_fp_mulmod.c:1192) ==135594== by 0x41C1B2: ecc_verify_hash_internal (ecc_verify_hash_internal.c:114) ==135594== by 0x41C830: ecc_verify_hash_rfc7518_internal (ecc_verify_hash_rfc7518.c:35) ==135594== by 0x40340F: time_ecc (timing.c:1031) ==135594== by 0x402894: main (timing.c:1621) ==135594== Address 0x20feffeb2f is not stack'd, malloc'd or (recently) free'd ``` The origin being `ltc_mp_unsigned_bin_size(tkb)` returning 0, so y is -1, but as an unsigned type that's no fun. Fixed by making y a signed type. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
We have to return an error code when working with the mutex API. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
We replace the PTHREAD job with `ECC_FP+PTHREAD` since PTHREAD is only relevant for ECC_FP and the PRNG's. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
sjaeckel
force-pushed
the
pr/fix-LTC_MECC_FP
branch
from
bdaaba6 to
9e1c617
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the branch
pr/fix-LTC_MECC_FPI have tried (unsuccessfully) to fixLTC_MECC_FPsupport.The fix does not work but before I invest more time into it I want to ask whether the
LTC_MECC_FPis worth to keep, or whether it could be removed.