Update KnuthBendix#449
Merged
Joseph-Edwards merged 7 commits intoJun 12, 2026
Merged
Conversation
Member
Author
|
This will fail until libsemigroups/libsemigroups#1004 is merged. |
| from .todd_coxeter import ToddCoxeter as _ToddCoxeter | ||
|
|
||
|
|
||
| # FIXME this function converts list[int] -> list, but shouldn't |
Collaborator
There was a problem hiding this comment.
I will open an issue for this and fix in due course
Collaborator
There was a problem hiding this comment.
Never mind; that issue is already open! I will still fix in due course.
Joseph-Edwards
approved these changes
Jun 12, 2026
Joseph-Edwards
left a comment
Joseph-Edwards
left a comment
Collaborator
There was a problem hiding this comment.
All looks good to me. Thanks @james-d-mitchell!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.