presentation: attempt to resolve #391#395
Open
james-d-mitchell wants to merge 4 commits intolibsemigroups:mainfrom
Open
presentation: attempt to resolve #391#395james-d-mitchell wants to merge 4 commits intolibsemigroups:mainfrom
james-d-mitchell wants to merge 4 commits intolibsemigroups:mainfrom
Conversation
Member
Author
|
I can't see why the MacOS CI jobs are failing, the logs don't provide enough info. It seems that libsemigroups_pybind11 builds okay, but then isn't loadable in python. I'm not going to investigate this further at this point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #391 by making
std::vector<word_type>andstd::vector<std::string>opaque types withinpresent.cppat least. The idea is that instead of such vectors being auto converted to lists, they are their own types.PROS:
p.rulesreturn a reference, (at least on my machine) the tests pass, and it's possible to dop.rules[0] = somethingand this actually works as expected.CONS:
p.rulesappears to be alist, but isn't, and so some things you might want to do with alistdon't work (likeindexfor example). This is a fairly large change.I think the PROS out weigh the CONS, but happy to hear your opinion too @Joseph-Edwards