Instrument git_submodule_set_url.#1395
Merged
jdavid merged 1 commit intolibgit2:masterfrom Aug 6, 2025
Merged
Conversation
Member
|
Looks good. Could you add a unit test? |
nrybowski
added a commit
to nrybowski/INGInious
that referenced
this pull request
Aug 6, 2025
This commit contains multiple changes. First, the core containers have been bumped to RockyLinux 10 to access the packaged version of python3.12. Second, the initial DB setup script has been updated to load an initial SSH private key for the superadmin. This key is used to authenticate on the gitolite instance. The frontend service image has been updated to leverage this extension of the DB setup script on service startup. Third, previous commits leverage a patched version of pygit2. While the patch libgit2/pygit2#1395 is not available through PyPi, we have to leverage a custom build of pygit2. However, the packaged libgit2 version on RL10 is too old for current versions of pygit2, hence we also have to custom build libgit2 and libssh2.
nrybowski
force-pushed
the
submodule_set_url
branch
from
5f25410 to
8814e4b
Compare
Contributor
Author
|
Sure, added with 8814e4b. |
Member
|
Thanks, the "ruff format" action fails, just a couple of missing blank lines, could you fix that? |
This commit adds a setter for the url property of the Submodule class. The new setter leverages 'git_submodule_set_url' from libgit2.
nrybowski
force-pushed
the
submodule_set_url
branch
from
8814e4b to
7cfc651
Compare
Contributor
Author
|
Fixed with 7cfc651. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a setter for the
urlproperty of theSubmoduleclass. The new setter leveragesgit_submodule_set_urlfrom libgit2.