Add RemoteCallbacks.push_transfer_progress#1345
Merged
jdavid merged 3 commits intolibgit2:masterfrom Feb 1, 2025
Merged
Conversation
This has been spurred by the introduction of RemoteCallbacks.push_transfer_progress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing callback
RemoteCallbacks.transfer_progressis only called during fetches, not pushes.This PR exposes libgit2's
push_transfer_progresscallback, allowing users to:Note: I had to rewrite test_push_options to use a real RemoteCallbacks object instead of a mock object (the mock wasn't complete enough to work with my additions to git_push_options)