Extend Electrum acceptance tests#801
Open
eynhaender wants to merge 5 commits into
Open
Conversation
Add pytest_report_header showing host, port, and offered protocol version. Extend electrum_config fixture to parse the protocol range (min:max) and expose subscription_timeout.
Tests for blockchain.headers.subscribe and blockchain.scripthash.subscribe. Each test opens its own connection, subscribes, and waits up to --subscription-timeout seconds for a notification before skipping.
Documents method support across v1.0-v1.6 (30+ methods), version-conditional assertion table, and known deviations from spec with the four intentional xfails.
Replace simple global socket with a session fixture that performs the version handshake and stores the negotiated protocol version. Add version-conditional assertions (response shape differs across v1.0-v1.6). Expand test coverage across all major method categories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the Electrum protocol test suite and adds push-notification tests.
Replace simple global socket in
test_electrum.pywith a session fixturethat performs the version handshake and stores the negotiated protocol
version; add version-conditional assertions (response shape differs across
v1.0–v1.6); expand test coverage across all major method categories.
Add
test_electrum_subscriptions.pyforblockchain.headers.subscribeand
blockchain.scripthash.subscribe; each test opens its own connectionand waits up to
--subscription-timeoutseconds for a push notificationbefore skipping.
Add
--electrum-protocoland--subscription-timeoutCLI options;add session header showing host, port, and offered protocol version.
Extend README with Electrum protocol version matrix (v1.0–v1.6, 30+
methods), version-conditional assertion table, and known deviations
from spec (four intentional xfails).