Skip to content

Fix multisig miss accounting, comments. #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 2 commits into from
Jun 11, 2026
Merged

Fix multisig miss accounting, comments. #1040

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85c38cd
Fix multisig miss accounting, comments.
evoskuil Jun 11, 2026
96b03c0
Delint.
evoskuil Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions src/chasers/chaser_validate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,29 +351,31 @@ code chaser_validate::validate(bool bypass, const chain::block& block,
// Enable/disable capture.
.enabled = batch_signatures_,

.log = [&](const script& missed) NOEXCEPT
.log = [&](const script& ) NOEXCEPT
{
////LOGA("Sigop @ " << ctx.height << " -> "
//// << missed.to_string(chain::flags::all_rules));
},
.fire = [&](signatures::miss miss) NOEXCEPT
.fire = [&](signatures::miss miss, size_t count) NOEXCEPT
{
switch (miss)
{
case signatures::miss::ecdsa:
++missed_ecdsa_;
missed_ecdsa_ += count;
////fire(events::missed_ecdsa, ctx.height);
break;
case signatures::miss::multisig:
++missed_multisig_;
missed_multisig_ += count;
////fire(events::missed_multisig, ctx.height);
break;
case signatures::miss::schnorr:
++missed_schnorr_;
missed_schnorr_ += count;
////fire(events::missed_schnorr, ctx.height);
break;
case signatures::miss::overflow:
++missed_threshold_;
// Misses overflow to single, so not called.
// This is instead used to reflect cache failure.
missed_threshold_ += count;
////fire(events::missed_overflow, ctx.height);
break;

Expand Down Expand Up @@ -438,10 +440,10 @@ code chaser_validate::validate(bool bypass, const chain::block& block,
<< "/(" << captured << "+" << missed << ")");
};

log_capture("ecdsa.... ", ecdsa_, missed_ecdsa_);
log_capture("multisig. ", multisig_, missed_multisig_);
log_capture("schnorr.. ", schnorr_, missed_schnorr_);
log_capture("threshold ", threshold_,missed_threshold_);
log_capture("ecdsa.... ", ecdsa_, missed_ecdsa_);
log_capture("multisig. ", multisig_, missed_multisig_);
log_capture("schnorr.. ", schnorr_, missed_schnorr_);
log_capture("threshold ", threshold_, missed_threshold_);
}
else
{
Expand Down
Loading