Skip to content

Add dependencies to our Netgen .buildstamp#4444

Merged
roystgnr merged 4 commits intolibMesh:develfrom
roystgnr:netgen_rebuild_fix
Apr 29, 2026
Merged

Add dependencies to our Netgen .buildstamp#4444
roystgnr merged 4 commits intolibMesh:develfrom
roystgnr:netgen_rebuild_fix

Conversation

@roystgnr
Copy link
Copy Markdown
Member

My recent update to our Netgen fork caused build failures in pre-existing build dirs, because it added a new API but our build system didn't realize that this required a recompile of part of Netgen. The workaround (rm contrib/netgen/.buildstamp) is simple to do but not simple for users to figure out, so let's try to make automatic compilation work correctly.

@moosebuild
Copy link
Copy Markdown

moosebuild commented Apr 24, 2026

Job Coverage, step Generate coverage on abc9cfb wanted to post the following:

Coverage

10e93d #4444 abc9cf
Total Total +/- New
Rate 65.47% 65.47% +0.00% -
Hits 78228 78229 +1 0
Misses 41256 41255 -1 0

Diff coverage report

Full coverage report

This comment will be updated on new commits.

We need to get some dependency checking for our netgen sub-make, or a
pre-existing libMesh build directory won't rebuild netgen when changes
require it.
@roystgnr roystgnr force-pushed the netgen_rebuild_fix branch from f256f95 to abc9cfb Compare April 24, 2026 23:15
@roystgnr
Copy link
Copy Markdown
Member Author

Test failure unrelated

@roystgnr roystgnr merged commit 505ce4e into libMesh:devel Apr 29, 2026
24 of 25 checks passed
@roystgnr roystgnr deleted the netgen_rebuild_fix branch April 29, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants