-
Notifications
You must be signed in to change notification settings - Fork 304
Kokkos support for Lagrange and Monomial elements #4441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Changes from all commits
c0e8657
c1eb62e
24be7bd
9026f1c
36be3f7
456ea05
1dc4dd1
1c43e29
230b4f0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -257,6 +257,12 @@ SUBDIRS += contrib | |
|
|
||
| include src/libmesh_SOURCES | ||
|
|
||
| # When Kokkos support is enabled, add the Kokkos FE type-conversion sources. | ||
| # These are kept in src/kokkos/ and not in src/libmesh_SOURCES (which is | ||
| # auto-generated) so that they don't affect non-Kokkos builds. | ||
| if LIBMESH_ENABLE_KOKKOS | ||
| endif | ||
|
Comment on lines
+263
to
+264
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, one more comment. There's an interesting story about the rock band Van Halen: When they were on tour, they had a fairly complicated and safety-critical set of contract stipulations that venues had to meet: heavy platforms and heavy equipment, serious electrical requirements, pyrotechnics, etc. And they had a little contract clause that demanded a bowl of M&Ms for them backstage, with all the brown M&Ms removed. If someone challenged that clause, they waived it. They didn't care about not eating brown M&Ms. They just cared that the big long critical pile of contract text had actually been respected, entirely read by the people with the primary responsibility of reading it and making sure everything was set up correctly. If they hadn't been reading carefully enough to notice the brown-M&M-hating-divas bit, could they really be trusted to be getting the subtle, tricky mechanical and electrical and thermal stuff done and inspected safely? No; the band roadies would essentially have to reinspect everything to see which parts of it they'd have to redo. It was not a good idea to be a venue that made the hard rock band and their annoyed roadies unable to trust any of your work.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, I mostly paid attention to the tests that were written, and once they all passed assumed the internal code was correct. That was clearly not a good idea. I will review everything now. The tests clearly didn't have enough coverage
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The claude generated comments had so many issues, it is terrifying how much it overclaims |
||
|
|
||
| # A convenience library to hold proper libMesh | ||
| # objects. This will get appended with any contributed | ||
| # sources to create the final library. | ||
|
|
||
Large diffs are not rendered by default.
| +2 −1 | configure | |
| +2 −1 | m4/kokkos.m4 | |
| +7 −6 | test/Makefile.am | |
| +7 −6 | test/Makefile.in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Definitely not.