Lab3 unit tests and coverage

.github/workflows/sonarcloud.yml

@@ -37,6 +37,8 @@ on:
 
 permissions:
   pull-requests: read # allows SonarCloud to decorate PRs with analysis results
+  contents: read
+
 
 jobs:
   sonar-check:
@@ -56,8 +58,8 @@ jobs:
           dotnet tool install --global dotnet-sonarscanner
           echo "$env:USERPROFILE\.dotnet\tools" >> $env:GITHUB_PATH
           dotnet sonarscanner begin `
-          /k:"ppanchen_NetSdrClient" `
-          /o:"ppanchen" `
+          /k:"slavik22_ReengineeringCourse" `
+          /o:"slavik22" `
           /d:sonar.token="${{ secrets.SONAR_TOKEN }}" `
           /d:sonar.cs.opencover.reportsPaths="**/coverage.xml" `
           /d:sonar.cpd.cs.minimumTokens=40 `
@@ -70,13 +72,13 @@ jobs:
         run: dotnet restore NetSdrClient.sln
       - name: Build
         run: dotnet build NetSdrClient.sln -c Release --no-restore
-      #- name: Tests with coverage (OpenCover)
-      #  run: |
-      #    dotnet test NetSdrClientAppTests/NetSdrClientAppTests.csproj -c Release --no-build `
-      #      /p:CollectCoverage=true `
-      #      /p:CoverletOutput=TestResults/coverage.xml `
-      #      /p:CoverletOutputFormat=opencover
-      #  shell: pwsh
+      - name: Tests with coverage (OpenCover)
+        run: |
+          dotnet test NetSdrClientAppTests/NetSdrClientAppTests.csproj -c Release --no-build `
+            /p:CollectCoverage=true `
+            /p:CoverletOutput=TestResults/coverage.xml `
+            /p:CoverletOutputFormat=opencover
+        shell: pwsh
       # 3) END: SonarScanner
       - name: SonarScanner End
         run: dotnet sonarscanner end /d:sonar.token="${{ secrets.SONAR_TOKEN }}"

NetSdrClientApp/Messages/NetSdrMessageHelper.cs

@@ -1,10 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Reflection.PortableExecutable;
-using System.Text;
-using System.Threading.Tasks;
-
+
 namespace NetSdrClientApp.Messages
 {
     //TODO: analyze possible use of [StructLayout] for better performance and readability 
@@ -83,7 +77,7 @@ public static bool TranslateMessage(byte[] msg, out MsgTypes type, out ControlIt
                 msgEnumarable = msgEnumarable.Skip(_msgControlItemLength);
                 msgLength -= _msgControlItemLength;
 
-                if (Enum.IsDefined(typeof(ControlItemCodes), value))
+                if (Enum.IsDefined(typeof(ControlItemCodes), (int)value))
                 {
                     itemCode = (ControlItemCodes)value;
                 }

NetSdrClientApp/NetSdrClient.cs

@@ -1,14 +1,6 @@
 using NetSdrClientApp.Messages;
 using NetSdrClientApp.Networking;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading;
-using System.Threading.Channels;
-using System.Threading.Tasks;
 using static NetSdrClientApp.Messages.NetSdrMessageHelper;
-using static System.Runtime.InteropServices.JavaScript.JSType;
 
 namespace NetSdrClientApp
 {

NetSdrClientApp/Networking/ITcpClient.cs

@@ -1,11 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-using static System.Runtime.InteropServices.JavaScript.JSType;
-
-namespace NetSdrClientApp.Networking
+namespace NetSdrClientApp.Networking
 {
     public interface ITcpClient
     {

NetSdrClientApp/Networking/TcpClientWrapper.cs

@@ -1,12 +1,5 @@
-using System;
-using System.Collections.Generic;
-using System.IO;
-using System.Linq;
-using System.Net.Http;
-using System.Net.Sockets;
+using System.Net.Sockets;
 using System.Text;
-using System.Threading;
-using System.Threading.Tasks;
 
 namespace NetSdrClientApp.Networking
 {

NetSdrClientApp/Networking/UdpClientWrapper.cs

@@ -1,10 +1,7 @@
-using System;
-using System.Net;
+using System.Net;
 using System.Net.Sockets;
 using System.Security.Cryptography;
 using System.Text;
-using System.Threading;
-using System.Threading.Tasks;
 
 public class UdpClientWrapper : IUdpClient
 {

NetSdrClientAppTests/NetSdrClientAppTests.csproj

@@ -11,6 +11,10 @@
 
   <ItemGroup>
     <PackageReference Include="coverlet.collector" Version="6.0.0" />
+    <PackageReference Include="coverlet.msbuild" Version="10.0.1">
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      <PrivateAssets>all</PrivateAssets>
+    </PackageReference>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
     <PackageReference Include="Moq" Version="4.20.72" />
     <PackageReference Include="NUnit" Version="3.14.0" />

NetSdrClientAppTests/NetSdrClientTests.cs

@@ -115,5 +115,29 @@ public async Task StopIQTest()
         Assert.That(_client.IQStarted, Is.False);
     }
 
+    [Test]
+    public async Task StopIQNoConnectionTest()
+    {
+        // act — no ConnectAsync, so Connected is false
+        await _client.StopIQAsync();
+
+        // assert
+        _tcpMock.Verify(tcp => tcp.SendMessageAsync(It.IsAny<byte[]>()), Times.Never);
+        _tcpMock.VerifyGet(tcp => tcp.Connected, Times.AtLeastOnce);
+    }
+
+    [Test]
+    public async Task ChangeFrequencyAsyncTest()
+    {
+        // arrange
+        await ConnectAsyncTest(); // 3 setup messages
+
+        // act
+        await _client.ChangeFrequencyAsync(20_000_000, 1);
+
+        // assert — 4th SendMessageAsync for frequency change
+        _tcpMock.Verify(tcp => tcp.SendMessageAsync(It.IsAny<byte[]>()), Times.Exactly(4));
+    }
+
     //TODO: cover the rest of the NetSdrClient code here
 }

NetSdrClientAppTests/NetSdrMessageHelperTests.cs

@@ -64,6 +64,46 @@ public void GetDataItemMessageTest()
             Assert.That(parametersBytes.Count(), Is.EqualTo(parametersLength));
         }
 
+        [Test]
+        public void TranslateMessageRoundTripTest()
+        {
+            // arrange — build a SetControlItem message then parse it back
+            var parameters = new byte[] { 0x01, 0x02, 0x03, 0x04, 0x05 };
+            var msg = NetSdrMessageHelper.GetControlItemMessage(
+                NetSdrMessageHelper.MsgTypes.SetControlItem,
+                NetSdrMessageHelper.ControlItemCodes.ReceiverFrequency,
+                parameters);
+
+            // act
+            bool success = NetSdrMessageHelper.TranslateMessage(msg,
+                out var type, out var itemCode, out _, out var body);
+
+            // assert
+            Assert.That(success, Is.True);
+            Assert.That(type, Is.EqualTo(NetSdrMessageHelper.MsgTypes.SetControlItem));
+            Assert.That(itemCode, Is.EqualTo(NetSdrMessageHelper.ControlItemCodes.ReceiverFrequency));
+            Assert.That(body, Is.EqualTo(parameters));
+        }
+
+        [Test]
+        public void GetSamples16BitReturnsCorrectCountTest()
+        {
+            // 6 bytes → 3 samples of 16 bits
+            var body = new byte[] { 0x01, 0x02, 0x03, 0x04, 0x05, 0x06 };
+
+            var samples = NetSdrMessageHelper.GetSamples(16, body).ToList();
+
+            Assert.That(samples.Count, Is.EqualTo(3));
+        }
+
+        [Test]
+        public void GetSamplesThrowsForOversizedBitsTest()
+        {
+            // 40 bits / 8 = 5 bytes > 4 → ArgumentOutOfRangeException
+            Assert.Throws<ArgumentOutOfRangeException>(() =>
+                NetSdrMessageHelper.GetSamples(40, new byte[8]).ToList());
+        }
+
         //TODO: add more NetSdrMessageHelper tests
     }
 }