Lab2 fix smells and bugs#38
Open
slavik22 wants to merge 11 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Коміт | Файл(и) | Що зробити
2 | NetSdrClient.cs, TcpClientWrapper.cs | git add тільки рядки readonly → commit fix: make private fields readonly (S2933)
3 | NetSdrClient.cs | видалення ; → commit fix: remove empty statement in StartIQAsync (S1116)
4 | NetSdrClient.cs | discards out _ → commit fix: replace unused out-params with discards (S1481)
5 | NetSdrClient.cs | nullable responseTaskSource → commit fix: declare responseTaskSource as nullable (CS8618)
6 | TcpClientWrapper.cs, UdpClientWrapper.cs | _cts nullable + _cts?.Dispose() → commit fix: dispose CancellationTokenSource to prevent resource leak (S2930)
7 | TcpClientWrapper.cs, UdpClientWrapper.cs | catch (... ex) → catch (...) → commit fix: remove unused exception variable in empty catch (S2486)
8 | IUdpClient.cs, UdpClientWrapper.cs | namespace wrap → commit fix: move IUdpClient and UdpClientWrapper into named namespace (S3903)
9 | NetSdrMessageHelper.cs | ArgumentOutOfRangeException з повідомленням → commit fix: provide message in ArgumentOutOfRangeException (S3928)
10 | UdpClientWrapper.cs | MD5.HashData → commit fix: use static MD5.HashData over ComputeHash (CA1850)