refactor(node): replace no-op publisher sentinels with None defaults#797
Merged
Merged
Conversation
The sync and validator services defaulted their publish callbacks to no-op async functions used purely as sentinels. Replace them with optional callables defaulting to None and guard each call site. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The sync and validator services defaulted their publish callbacks to no-op async functions (
_noop_publish_agg,_noop_block_publisher,_noop_attestation_publisher) used purely as sentinels. This replaces them with optional callables defaulting toNoneand guards each call site — a simpler, more honest signature with no behavior change.Changes
sync/service.py: Delete_noop_publish_agg;publish_aggregated_attestationis nowCallable[...] | None = None. The drain method clears its queue first (preserving the original always-clear behavior), then guards the publish call.validator/service.py: Delete_noop_block_publisherand_noop_attestation_publisher;on_blockandon_attestationare now... | None = None, withis not Noneguards at both emit sites.chain/service.py: Bind the publisher to a local and guard before awaiting in the tick loop.tests/.../test_node.py: The two tests invoking the wired publishers directly now assert non-None first.Verification
just check— all green (ruff, format, ty, codespell, mdformat, lock).🤖 Generated with Claude Code