chore: Update sdk_metadata features#115
chore: Update sdk_metadata features#115devin-ai-integration[bot] wants to merge 5 commits intomainfrom
Conversation
Co-Authored-By: Aaron Zeisler <azeisler@launchdarkly.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Aaron Zeisler <azeisler@launchdarkly.com>
|
Devin: I believe the |
Co-Authored-By: Aaron Zeisler <azeisler@launchdarkly.com>
|
Done — added |
|
Devin, this SDK is a wrapper around the C++ server SDK, so some features are inherited from it. In this SDK you may have to check the code for some features. For example "appMetadata" is supported in our C++ server SDK, and lua has |
|
Co-Authored-By: Aaron Zeisler <azeisler@launchdarkly.com>
|
Good catch — added both inherited features from the C++ server SDK:
I also checked for other C++ server SDK features (hooks, bigSegments, webProxy, testData, fileData) but none of those are exposed in the Lua SDK code. Now 13 features total. |
.sdk_metadata.json
Outdated
| "wrapperNames": ["lua-server-sdk"], | ||
| "features": { | ||
| "allFlags": { "introduced": "1.0" }, | ||
| "appMetadata": { "introduced": "1.0" }, |
There was a problem hiding this comment.
Devin, this looks like it was introduced in this PR: 95e9718
Which would not correlate to 1.0.
There was a problem hiding this comment.
You're right — I checked the git history and commit 95e9718 (feat!: use C++ Server-side SDK 3.0 bindings) is the first one that adds config.appInfo. The earliest tag containing that commit is v2.0.0, so I've corrected appMetadata from 1.0 → 2.0.
Note: offlineMode remains at 1.0 because the offline config option was present since 1.0.0-beta.3 (commit c4917d9).
Co-Authored-By: Aaron Zeisler <azeisler@launchdarkly.com>
Requirements
Related issues
Part of a cross-repo effort to populate
featuresin.sdk_metadata.jsonfor all LaunchDarkly SDKs.Describe the solution you've provided
Adds a
featuresmap to thelua-server-sdkentry in.sdk_metadata.json, documenting which SDK features are supported and the version they were introduced. Feature keys use the canonical camelCase names from sdk-meta/feature_info.json, and introduction versions are sourced from the SDK features documentation table (server-side SDKs L-Z, Lua column) and verified against CHANGELOG.md and source code.Features included (13 total, alphabetical):
allFlags,appMetadata,contexts,experimentation,inlineContextCustomEvents,offlineMode,privateAttrs,relayProxyDaemon,relayProxyProxy,storingData,storingDataRedis,track,variationDetail.Updates since last revision
contextswith introduced version"2.0"— verified against CHANGELOG.md entry under## [2.0.0].storingDataRediswith introduced version"1.0"— verified against CHANGELOG.md entry under1.0.0-beta.3. Version1.0used since pre-1.0 releases were betas.appMetadataandofflineMode— inherited from the C++ server SDK. The Lua SDK wraps the C++ server SDK and exposesconfig.appInfoandconfig.offlinefields.appMetadatafrom"1.0"to"2.0"— git history showsconfig.appInfowas first introduced in commit95e9718(feat!: use C++ Server-side SDK 3.0 bindings), whose earliest tag isv2.0.0.offlineModeremains at"1.0"becauseconfig.offlinewas present since1.0.0-beta.3.Human review checklist
contextsat"2.0"andstoringDataRedisat"1.0"were verified against CHANGELOG.mdstoringDataRedis: "1.0"— the Redis module was introduced in1.0.0-beta.3. Verified that1.0is the correct version to use (consistent with the convention that pre-1.0 betas are not counted)appMetadata: "2.0"— corrected from1.0after review. Commit95e9718(C++ SDK 3.0 bindings) is the first to addconfig.appInfo, and the earliest tag containing it isv2.0.0offlineMode: "1.0"—config.offlinewas present in1.0.0-beta.3(commitc4917d9), so1.0is correctinlineContextCustomEventsversion"2.1.3"— this is a patch-level version; confirm it is correctAdditional context
Link to Devin session
Requested by: Aaron Zeisler
Note
Low Risk
Low risk metadata-only update; no runtime code paths change, but downstream consumers of
.sdk_metadata.jsonmay alter behavior based on the newly declared feature set/versions.Overview
Adds a
featuresmap to thelua-server-sdkentry in.sdk_metadata.json, documenting supported SDK capabilities and the version each was introduced (e.g.,contextsat2.0,inlineContextCustomEventsat2.1.3, plus other core features likeallFlags,track, andvariationDetail).Written by Cursor Bugbot for commit 3bf8bb0. This will update automatically on new commits. Configure here.