Skip to content

feat(REL-12779): Add a command to sign up that directs the user to the sign up page#665

Open
LindseyB wants to merge 1 commit intomainfrom
sign-up-command
Open

feat(REL-12779): Add a command to sign up that directs the user to the sign up page#665
LindseyB wants to merge 1 commit intomainfrom
sign-up-command

Conversation

@LindseyB
Copy link

@LindseyB LindseyB commented Mar 18, 2026

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

https://launchdarkly.atlassian.net/browse/REL-12779

Describe the solution you've provided

This pull request adds a new signup command to the CLI, allowing users to easily open a browser and create a new LaunchDarkly account. The implementation includes the command itself, integration into the CLI, updates to help text, and a basic test for the new command.

New Signup Command Integration

  • Added a new signup command in cmd/signup/signup.go, which opens the user's browser to the LaunchDarkly signup page and tracks analytics for the command run.
  • Integrated the new signup command into the CLI by importing it, registering it in the root command, and including it in the list of commands that disable flag parsing when used as a parent. (cmd/root.go) [1] [2] [3]

User Experience Improvements

  • Updated the CLI help templates to include the new signup command in the list of available commands. (cmd/templates.go)

Testing

  • Added a unit test for the signup command to verify its attributes and ensure it is created correctly. (cmd/signup/signup_test.go)

Describe alternatives you've considered

Not adding this at all? But fundamentally we need to get the data.

Additional context

Screenshot 2026-03-18 at 3 44 27 PM

Note

Low Risk
Low risk: adds a small, isolated CLI command and help text with minimal interaction with existing logic. Main risk is minor UX/platform behavior differences when auto-opening a browser or constructing the signup URL from base-uri.

Overview
Adds a new top-level ldcli signup command that opens the user’s browser to the /signup page (based on the configured base-uri) and emits the standard command-run analytics event.

Wires signup into the root command (including disabling required flag parsing for it as a parent) and updates the usage template to list it; includes a basic unit test asserting the command metadata and handlers are set.

Written by Cursor Bugbot for commit 88b9412. This will update automatically on new commits. Configure here.


Related Jira issue: REL-12779: Add signup command to CLI to determine usage and to point folks to signup

@LindseyB LindseyB requested review from Copilot and nieblara March 18, 2026 22:51
@LindseyB LindseyB changed the title feat(REL-12779) Add a command to sign up that directs the user to the sign up page feat(REL-12779): Add a command to sign up that directs the user to the sign up page Mar 18, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new top-level signup command to the LaunchDarkly CLI to open the user’s browser to a signup page, while integrating the command into the root command registration and CLI help output.

Changes:

  • Introduced cmd/signup package with signup Cobra command and analytics tracking hook.
  • Registered signup in the root command and in the “disable flag parsing” list.
  • Updated the CLI usage template to list signup, and added a basic unit test for command construction.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
cmd/signup/signup.go New signup command implementation (browser open + analytics event).
cmd/signup/signup_test.go Unit test asserting command attributes are set as expected.
cmd/root.go Wires the new command into the CLI and adjusts flag parsing behavior list.
cmd/templates.go Adds signup to the rendered help/usage command list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LindseyB LindseyB marked this pull request as ready for review March 18, 2026 23:07
@LindseyB LindseyB requested a review from a team March 18, 2026 23:08
Copy link
Contributor

@ldhenry ldhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative here, @LindseyB 🥇

Copy link

@ari-launchdarkly ari-launchdarkly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if we'll be able to simplify our sign-up process so that users could theoretically just set the required data in the CLI rather than being sent to the signup URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants