feat(REL-12779): Add a command to sign up that directs the user to the sign up page#665
Open
feat(REL-12779): Add a command to sign up that directs the user to the sign up page#665
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new top-level signup command to the LaunchDarkly CLI to open the user’s browser to a signup page, while integrating the command into the root command registration and CLI help output.
Changes:
- Introduced
cmd/signuppackage withsignupCobra command and analytics tracking hook. - Registered
signupin the root command and in the “disable flag parsing” list. - Updated the CLI usage template to list
signup, and added a basic unit test for command construction.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/signup/signup.go | New signup command implementation (browser open + analytics event). |
| cmd/signup/signup_test.go | Unit test asserting command attributes are set as expected. |
| cmd/root.go | Wires the new command into the CLI and adjusts flag parsing behavior list. |
| cmd/templates.go | Adds signup to the rendered help/usage command list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4d17e51 to
88b9412
Compare
ari-launchdarkly
approved these changes
Mar 19, 2026
ari-launchdarkly
left a comment
There was a problem hiding this comment.
LGTM. I wonder if we'll be able to simplify our sign-up process so that users could theoretically just set the required data in the CLI rather than being sent to the signup URL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
https://launchdarkly.atlassian.net/browse/REL-12779
Describe the solution you've provided
This pull request adds a new
signupcommand to the CLI, allowing users to easily open a browser and create a new LaunchDarkly account. The implementation includes the command itself, integration into the CLI, updates to help text, and a basic test for the new command.New Signup Command Integration
signupcommand incmd/signup/signup.go, which opens the user's browser to the LaunchDarkly signup page and tracks analytics for the command run.signupcommand into the CLI by importing it, registering it in the root command, and including it in the list of commands that disable flag parsing when used as a parent. (cmd/root.go) [1] [2] [3]User Experience Improvements
signupcommand in the list of available commands. (cmd/templates.go)Testing
signupcommand to verify its attributes and ensure it is created correctly. (cmd/signup/signup_test.go)Describe alternatives you've considered
Not adding this at all? But fundamentally we need to get the data.
Additional context
Note
Low Risk
Low risk: adds a small, isolated CLI command and help text with minimal interaction with existing logic. Main risk is minor UX/platform behavior differences when auto-opening a browser or constructing the signup URL from
base-uri.Overview
Adds a new top-level
ldcli signupcommand that opens the user’s browser to the/signuppage (based on the configuredbase-uri) and emits the standard command-run analytics event.Wires
signupinto the root command (including disabling required flag parsing for it as a parent) and updates the usage template to list it; includes a basic unit test asserting the command metadata and handlers are set.Written by Cursor Bugbot for commit 88b9412. This will update automatically on new commits. Configure here.
Related Jira issue: REL-12779: Add signup command to CLI to determine usage and to point folks to signup