chore: mode resolution and switching (different approach)#327
Closed
aaron-zeisler wants to merge 2 commits intomainfrom
Closed
chore: mode resolution and switching (different approach)#327aaron-zeisler wants to merge 2 commits intomainfrom
aaron-zeisler wants to merge 2 commits intomainfrom
Conversation
Contributor
|
Update title to use 'chore:' prefix to avoid triggering a release PR. |
Contributor
|
If you do decide to use the approach from this PR, I think it would be better to merge it into the other one to keep one PR with comment history. |
This is another take on FDv2 mode resolution and switching.
82c617f to
b97a7b4
Compare
Author
|
I've merged the code from this approach into #326 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress: This is a different approach to mode switching
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.