Reuse the TLS connector across connection attempts#4242
Open
goffrie wants to merge 2 commits intolaunchbadge:mainfrom
Open
Reuse the TLS connector across connection attempts#4242goffrie wants to merge 2 commits intolaunchbadge:mainfrom
goffrie wants to merge 2 commits intolaunchbadge:mainfrom
Conversation
goffrie
force-pushed
the
tls-cache
branch
2 times, most recently
from
0a96412 to
9db9a93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a TLS connector (native_tls::TlsConnector or rustls::ClientConfig) is often expensive, primarily because it needs to load and parse the trusted roots. However, TLS settings are rarely changed during a pool's lifecycle, so the cost can be amortized by reusing the connector.
This PR:
Arc<OnceLock>so that clones of the same ConnectOptions will share TLS connectors. The cache is cleared if any relevant settings are changed.To avoid behaviour changes we still create the connector at the moment that it's first needed, and only cache it if the connector was successfully created.
Does your PR solve an issue?
no
Is this a breaking change?
No; it is only a breaking change in sqlx-core which is not subject to semver