Open
Conversation
abonander
requested changes
Apr 6, 2026
| Ok(v) => v, | ||
| // The behavior is similar to what was observed when using SASLprep for username. | ||
| // TODO: Remove panic when we have proper support for configuration errors | ||
| Err(_) => panic!("Failed to saslprep password"), |
Collaborator
There was a problem hiding this comment.
This is copying a panic from earlier in this file which is really, really old code. Can we avoid adding a new one? This could just return Error::Configuration.
In fact, if you'd like to go ahead and replace the other panic!() as well, that would be a solid improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
fixes #4196
Is this a breaking change?
No.