Improve a couple of test docstrings#362
Merged
Merged
Conversation
I thought we were missing a test - it turns out the test is already here. As I'm in the code anyway, I have taken the opportunity to improve the docstrings, and to test both Things in the server rather than just one of them.
Barecheck - Code coverage reportTotal: 96.97%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Collaborator
Author
|
The unpinned tests fail because of a new/updated ruff rule, which should be fixed separately. I don't think it needs to hold this up. |
bprobert97
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked at the code testing
/things/and/thing_descriptions/when investigating #358. I thought we were missing a test - it turns out the test is already here, I'd added it when I fixed the issue forv0.2.0and I was just looking at a microscope with an old version of LabThings.As I was in the code anyway, I have taken the opportunity to improve the docstrings, and to test both Things in the server rather than just one of them.