fix: update CLI nav script to target config/navigation.json#177
Merged
dangrondahl merged 1 commit intomainfrom Apr 23, 2026
Merged
fix: update CLI nav script to target config/navigation.json#177dangrondahl merged 1 commit intomainfrom
dangrondahl merged 1 commit intomainfrom
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
The script was writing to docs.json, but navigation moved to config/navigation.json via $ref. The script silently found no matching structure and wrote docs.json back unchanged. Changes: - Script now reads/writes config/navigation.json directly - Errors if CLI Reference section is not found (no more silent failure) - Workflow updated to pass --nav-file config/navigation.json - Renamed --config flag to --nav-file for clarity Closes #174
dangrondahl
force-pushed
the
fix/174-update-cli-nav-script
branch
from
fa9af6b to
789a876
Compare
JonJagger
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/update-cli-nav.pyto read/writeconfig/navigation.jsondirectly instead ofdocs.json.github/workflows/update-cli-docs.ymlto pass--nav-file config/navigation.jsonkosli evaluate inputnav entry (same as fix: add missing kosli evaluate input to CLI navigation #176)Root cause: When navigation was split from
docs.jsonintoconfig/navigation.jsonvia$ref, the script kept targetingdocs.jsonwhere it found{"$ref": ...}instead of the actual nav structure.Closes #174