fix: update GitHub contract test fixture to a commit the API still associates with a PR

[jumboduck]

GitHub's associatedPullRequests API intermittently drops associations for
older commits. Bump the fixture from e21a8af (PR #6, broken) to
475dd3d (PR #829, recent and verified).

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com

[claude]

Claude finished @jumboduck's task in 3m 6s —— View job

---

PR Review: Update GitHub contract test fixture

• Run static analysis (build, vet, mod tidy)
• Read changed files and understand the diff
• Review code quality, correctness, and test coverage
• Post review feedback

---

Static Analysis

All checks pass — go build, go vet, and go mod tidy produce no issues.

Review

Verified the new fixture data is correct. gh pr view 829 confirms PR #829 is MERGED with merge commit 475dd3d1fe69f0d64057defeb0504aad2e132e9d, matching the values in the PR. The commit exists in the repo. All 4 call sites (GithubCommitWithPR() and GithubPRNumber()) are updated consistently between the two changed files.

The comment rewrite in testHelpers.go is a nice improvement — the old comment was vague ("for reasons we cannot fathom"), while the new version documents the pattern clearly and keeps a breadcrumb trail of previous values. This will save future debugging time when GitHub inevitably drops another association.

One nit (outside the diff)

In internal/github/github_contract_test.go:136, the hybrid fallback test still hardcodes URL: "https://github.com/kosli-dev/cli/pull/6", but prNumber now comes from testHelpers.GithubPRNumber() which returns 829. The test passes because it compares the fake data against itself, so there's no functional bug — but the PR number and URL are inconsistent, which could confuse a future reader. Worth updating to /pull/829 for consistency (or using fmt.Sprintf with GithubPRNumber()).

Summary

Clean, minimal fix. LGTM with the optional nit above.

[mbevc1]

🤦