Skip to content

fix: properly commit tab name changes.#90

Merged
knightedcodemonkey merged 1 commit intonextfrom
bananas
Apr 23, 2026
Merged

fix: properly commit tab name changes.#90
knightedcodemonkey merged 1 commit intonextfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings April 23, 2026 15:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes push-commit behavior for renamed workspace tabs by ensuring a rename is represented as an add/update of the new path plus a delete of the previously-synced path, and that the confirmation summary reflects those operations.

Changes:

  • Track and propagate a deleted flag through PR drawer file commits and submission flow.
  • Update Git Database API tree creation to delete files via sha: null entries.
  • Mark tabs as Edited when their path changes due to a rename, and add a Playwright regression test covering rename + push-commit.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/modules/github/pr/drawer/summary.js Show (delete) in the commit confirmation summary for deletion entries.
src/modules/github/pr/drawer/file-commits.js Normalize deleted onto file commit objects.
src/modules/github/pr/drawer/controller/run-submit.js Convert deleted file commits into { path, deleted: true } file updates.
src/modules/github/api/editor-content.js Support deletions in Git Database API commits by emitting tree entries with sha: null.
src/modules/app-core/workspace-tab-mutations-controller.js Mark a tab dirty when a rename changes its path (even if content is unchanged).
src/modules/app-core/workspace-sync-controller.js Detect committed renames and emit a delete update for the previous synced path when needed.
playwright/github-pr-drawer.spec.ts Add end-to-end coverage verifying rename marks Edited, confirmation lists new+delete paths, and tree payload includes sha: null for the deleted file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit 1e42998 into next Apr 23, 2026
19 of 25 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch April 23, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants