fix: properly commit tab name changes.#90
Merged
knightedcodemonkey merged 1 commit intonextfrom Apr 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes push-commit behavior for renamed workspace tabs by ensuring a rename is represented as an add/update of the new path plus a delete of the previously-synced path, and that the confirmation summary reflects those operations.
Changes:
- Track and propagate a
deletedflag through PR drawer file commits and submission flow. - Update Git Database API tree creation to delete files via
sha: nullentries. - Mark tabs as Edited when their path changes due to a rename, and add a Playwright regression test covering rename + push-commit.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/github/pr/drawer/summary.js | Show (delete) in the commit confirmation summary for deletion entries. |
| src/modules/github/pr/drawer/file-commits.js | Normalize deleted onto file commit objects. |
| src/modules/github/pr/drawer/controller/run-submit.js | Convert deleted file commits into { path, deleted: true } file updates. |
| src/modules/github/api/editor-content.js | Support deletions in Git Database API commits by emitting tree entries with sha: null. |
| src/modules/app-core/workspace-tab-mutations-controller.js | Mark a tab dirty when a rename changes its path (even if content is unchanged). |
| src/modules/app-core/workspace-sync-controller.js | Detect committed renames and emit a delete update for the previous synced path when needed. |
| playwright/github-pr-drawer.spec.ts | Add end-to-end coverage verifying rename marks Edited, confirmation lists new+delete paths, and tree payload includes sha: null for the deleted file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.