feat: add platform support to pack builder#3603
Open
matejvasek wants to merge 1 commit intoknative:mainfrom
Open
feat: add platform support to pack builder#3603matejvasek wants to merge 1 commit intoknative:mainfrom
matejvasek wants to merge 1 commit intoknative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
approved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3603 +/- ##
==========================================
- Coverage 56.26% 56.25% -0.02%
==========================================
Files 180 180
Lines 20504 20522 +18
==========================================
+ Hits 11537 11544 +7
- Misses 7762 7775 +13
+ Partials 1205 1203 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The pack builder previously rejected any --platform flag with a hard error. Since the pack library already supports a Platform field in BuildOptions, this enables single-platform builds following the same pattern as the s2i builder: resolve the builder image via docker.GetPlatformImage and set opts.Platform so pack also pulls the correct run image. Multiple platforms are still rejected with a clear error, and omitting --platform continues to work as before. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Matej Vašek <matejvasek@gmail.com>
matejvasek
force-pushed
the
platform-pack
branch
from
b5ae505 to
280321f
Compare
Contributor
Author
|
ptal @lkingland @gauron99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
feat: add platform support to pack builder
The pack builder previously rejected any --platform flag with a hard error. Since the pack library already supports a Platform field in BuildOptions, this enables single-platform builds following the same pattern as the s2i builder: resolve the builder image via docker.GetPlatformImage and set opts.Platform so pack also pulls the correct run image.
Multiple platforms are still rejected with a clear error, and omitting --platform continues to work as before.