fastapi: bugfix after upgrade, replace fastapi-versioning by native include_router.#665
Merged
nuclearcat merged 1 commit intokernelci:mainfrom Apr 9, 2026
Merged
Conversation
…nclude_router. fastapi-versioning transplants route objects by directly appending them to sub-app router.routes. In New FastAPI + Starlette this doesnt work properly. Let's replace VersionedFastAPI with include_router, which properly re-creates APIRoute objects through APIRoute.__init__ — ensuring FastAPI's request_response wrapper is used. P.S. fastapi-versioning and fastapi-users are both poorly maintained and source of many issues. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
nuclearcat
force-pushed
the
fix-after-upgrade
branch
from
156d0d1 to
c00c8fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fastapi-versioning transplants route objects by directly appending them to sub-app router.routes. In New FastAPI + Starlette this doesnt work properly. Let's replace VersionedFastAPI with include_router, which properly re-creates APIRoute objects through APIRoute.init — ensuring FastAPI's request_response wrapper is used. P.S. fastapi-versioning and fastapi-users are both poorly maintained and source of many issues.