Conversation
Subscribes this repo to the shared Semgrep workflow in kernel/security-workflows as part of expanding the elevated vulnerability management scope to customer-facing SDKs (KERNEL-1191, INC-51 follow-up). Made-with: Cursor
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: This PR only adds CI/CD configuration (Semgrep scanning workflow) and does not change any kernel API endpoints or Temporal workflows. To monitor this PR anyway, reply with |
ulziibay-kernel
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up from the INC-51 postmortem (KERNEL-1191): the Kernel MCP vulnerability was missed in part because the MCP repo was not subscribed to the shared Semgrep workflow. Expanding the scope to the customer-facing SDKs so the same gap can't happen there.
This PR adds
.github/workflows/semgrep.ymlthat calls the reusable workflow in kernel/security-workflows. Runs on every PR targeting `main` with the agent-powered triage flow already used in `kernel`, `kernel-images`, `cli`, `kernel-mcp-server`, etc.Semgrep configs: `p/javascript`, `p/typescript`, `p/trailofbits`.
Uses org-level secrets already provisioned for existing subscribers (`CURSOR_API_KEY`, `CURSOR_PREFERRED_MODEL`, `ADMIN_APP_ID`, `ADMIN_APP_PRIVATE_KEY`, `SOCKET_API_TOKEN`) via `secrets: inherit`.
Stainless caveat
This SDK is Stainless-generated. Stainless doesn't appear to manage arbitrary files under `.github/workflows/`, but if the next regeneration wipes this file, we'll need to either add it to the Stainless config or restore it via a post-generation step.
Test plan
Made with Cursor
Note
Medium Risk
Introduces a new CI job that runs a reusable workflow with
secrets: inheritandpull-requests: writepermissions, so misconfiguration could expose secrets or enable unwanted PR comments. Otherwise it’s isolated to CI and doesn’t change runtime behavior.Overview
Adds a new GitHub Actions workflow,
.github/workflows/semgrep.yml, that runs on PRs targetingmainand invokes the sharedkernel/security-workflowsSemgrep workflow.The scan is configured with the
p/javascript,p/typescript, andp/trailofbitsrule sets and grants the job PR write permissions (to post results) while inheriting org secrets.Reviewed by Cursor Bugbot for commit 1db0f13. Bugbot is set up for automated code reviews on this repo. Configure here.