Fix/footer bug for mobile view#794
Conversation
|
Kindly review this PR when possible. Thank you! |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Previous Issues - Now ResolvedThe two warnings from the previous review have been fixed:
Files Reviewed (1 file)
Incremental review of commit changes since 11da2bc Reviewed by claude-4.5-opus-20251124 · 74,320 tokens |
amaan-bhati
left a comment
There was a problem hiding this comment.
Thank you for catching the className to class correction in docusaurus.config.js and for the mobile footer fix — the intent here is clear and appreciated.
A couple of things to address before this is ready to merge:
Issues Found
1. CSS rules not scoped to mobile
The new rules .footer__copyright+div and .footer__icons.footer have no media query, which means the center-alignment applies at all screen sizes. If the footer is intentionally left-aligned on desktop this could be an unintended regression. Please wrap these in an appropriate media query:
@media (max-width: 768px) {
.footer__copyright+div {
text-align: center;
}
.footer__icons.footer {
text-align: center;
}
}Unless center-alignment is intentional for all viewports, in which case please confirm that explicitly.
2. Missing screenshots
Please provide before/after screenshots showing both mobile and desktop views to confirm there is no desktop regression.
Please also rebase against main before resubmitting as there are merge conflicts with other open PRs touching the same file.
3b39b43 to
7d623f0
Compare
amaan-bhati
left a comment
There was a problem hiding this comment.
Thank you for the before and after screenshots - they make the fix very easy to assess visually, and the footer alignment improvement on mobile is clear. Using 996px to match the project's existing breakpoints is a sensible choice.
One issue still needs to be addressed before this is ready:
Issues to be Considered:
-
The CSS still uses
text-align: -webkit-centeron both.footer__copyright+divand.footer__icons.footer. This is a non-standard, deprecated vendor-prefixed value that does not work in Firefox and may produce inconsistent results across browsers. Please replace both instances with the standardtext-align: center. An earlier automated review noted this as resolved, but the current diff still shows the deprecated value in both rules. -
The media query block is missing a blank line and indentation consistency - the
.footer__copyright+divselector opens flush against the@mediarule. Minor formatting point but worth keeping clean to avoid noisy diffs.
One targeted fix and this should be good to go. Thank you for sticking with it!
khanparaYash
left a comment
There was a problem hiding this comment.
Thanks for the detailed feedback!
I’ve replaced the deprecated -webkit-center with the standard center value and cleaned up the media query formatting for consistency.
Please take another look.
Signed-off-by: yash khanpara <158573701+khanparaYash@users.noreply.github.com>
Signed-off-by: yash khanpara <158573701+khanparaYash@users.noreply.github.com>
Co-authored-by: kilo-code-bot[bot] <240665456+kilo-code-bot[bot]@users.noreply.github.com> Signed-off-by: yash khanpara <158573701+khanparaYash@users.noreply.github.com>
Co-authored-by: kilo-code-bot[bot] <240665456+kilo-code-bot[bot]@users.noreply.github.com> Signed-off-by: yash khanpara <158573701+khanparaYash@users.noreply.github.com>
Thanks for the detailed feedback! I’ve replaced the deprecated `-webkit-center` with the standard `center` value and cleaned up the media query formatting for consistency. Please take another look. Signed-off-by: yash khanpara <158573701+khanparaYash@users.noreply.github.com>
4482e76 to
c5bb7bd
Compare




What has changed?
This PR fixes the footer alignment issue on mobile view by properly centering the footer content.
The following changes were made:
classNameattribute withclassin HTML to ensure proper rendering.This PR Resolves #(issue_number)
Type of change
How Has This Been Tested?
npm run buildsuccessfully without errors.npm run serveand verified the footer alignment on mobile view.(Screenshots attached showing before and after changes.)
Checklist:
-Before fix (misaligned footer)

After fix (centered footer on mobile)
