Add ability to save the current offset as a variable#89
Closed
ayan4m1 wants to merge 5 commits intokeichi:masterfrom
Closed
Add ability to save the current offset as a variable#89ayan4m1 wants to merge 5 commits intokeichi:masterfrom
ayan4m1 wants to merge 5 commits intokeichi:masterfrom
Conversation
Contributor
|
I think this is a better approach than my breaking change here: #86 Our use case for this is to check that we read the correct amount of bytes out of the buffer. Would be good if we could update this to be equal with master |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is similar to #69, but should be more flexible in that you can store many offsets as variables and use any of them in any of the other parsers.
My use case is
.uassetfiles, where there is an absolute byte offset stored in the file as an integer - I need to seek to the absolute position from an arbitrary offset, thus I need the "current" offset stored as a variable that a subsequent call toskip()can access.I have added documentation and test cases.
Thank you for your time and effort.