Fix objective sensitivity when parameters appear in the objective#337
Merged
andrewrosemberg merged 2 commits intojump-dev:masterfrom Feb 14, 2026
Merged
Fix objective sensitivity when parameters appear in the objective#337andrewrosemberg merged 2 commits intojump-dev:masterfrom
andrewrosemberg merged 2 commits intojump-dev:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 89.14% 89.17% +0.02%
==========================================
Files 16 16
Lines 1963 1967 +4
==========================================
+ Hits 1750 1754 +4
Misses 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewrosemberg
approved these changes
Feb 13, 2026
Collaborator
andrewrosemberg
left a comment
andrewrosemberg
left a comment
There was a problem hiding this comment.
LGTM nice catch
Collaborator
|
Should we do a minor bump to indicate bug fix? then release a the new version? |
Collaborator
|
I accidentally clicked merge :( |
Collaborator
|
do you mind reopening? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiffOpt was ignoring the direct parameter contribution. The added test fails before this change (DiffOpt gets 0 but finite diff gets 0.6)
It may be relevant for #330
@andrewrosemberg